Skip to content

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented May 21, 2025

Summary

When we removed the REST API in #6578 we missed that the geocoder sandbox feature, used by Arcadis, had a dependency on the custom serializer for feed-scoped ids. This meant that the output for IDs in the geocoder endpoint changed.

This PR restores the old behaviour by adding a custom serializer to the sandbox code.

Issue

Not issue, since this is a sandbox feature.

Unit tests

Added.

cc @miles-grant-ibigroup

Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.31%. Comparing base (2513946) to head (d6bc473).
Report is 16 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6671   +/-   ##
==========================================
  Coverage      71.31%   71.31%           
+ Complexity     18518    18517    -1     
==========================================
  Files           2031     2031           
  Lines          76460    76462    +2     
  Branches        7820     7820           
==========================================
+ Hits           54524    54526    +2     
  Misses         19165    19165           
  Partials        2771     2771           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leonardehrenfried
Copy link
Member Author

This only touches the sandbox so I will merge with one reviewer.

@leonardehrenfried leonardehrenfried merged commit 18a13c3 into opentripplanner:dev-2.x May 21, 2025
7 checks passed
@leonardehrenfried leonardehrenfried deleted the geocoder-id branch May 21, 2025 15:12
@leonardehrenfried leonardehrenfried added this to the 2.8 (next release) milestone May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants