Enable CAR transfers with ferries with NeTEx import #6640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2gran
added
Improvement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6640 +/- ##
==========================================
Coverage 71.16% 71.17%
- Complexity 18453 18463 +10
==========================================
Files 2027 2027
Lines 76296 76312 +16
Branches 7807 7807
==========================================
+ Hits 54295 54313 +18
+ Misses 19238 19237 -1
+ Partials 2763 2762 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t2gran
changed the title
habrahamsson-skanetrafiken
requested review from
vpaturet and
habrahamsson-skanetrafiken
habrahamsson-skanetrafiken
requested changes
May 9, 2025
application/src/main/java/org/opentripplanner/netex/mapping/TransportModeMapper.java
Outdated
Show resolved
Hide resolved
vpaturet
requested changes
May 13, 2025
application/src/main/java/org/opentripplanner/netex/mapping/TransportModeMapper.java
Outdated
Show resolved
Hide resolved
vpaturet
approved these changes
May 15, 2025
habrahamsson-skanetrafiken
approved these changes
May 15, 2025
t2gran
pushed a commit
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will set the
Trip#carsAllowedflag based on submodes in NeTEx. This will enable routing with CAR + FERRY. The submodes that enable thecarsAllowedflag is:NATIONAL_CAR_FERRY(WATER)REGIONAL_CAR_FERRY(WATER)LOCAL_CAR_FERRY(WATER)HIGH_SPEED_VEHICLE_SERVICE(WATER)There are other modes witch also might take cars on board like the
CAR_TRANSPORT_RAIL_SERVICE.At the moment we assume all stops used by a service with the submodes above is car accessible. This is not true in all cases. To account for this we need to know if a stop is car accessible, but this information does not exist in the Norwegian NeTEx data at the moment.
Issue
🟥 There is no issue for this.
Unit tests
✅ I have added unit-tests for the NeTEx mapping.
Documentation
Only JavaDoc is added.
Changelog
✅ This should be included.
Bumping the serialization version id
🟥 No changes to the serialized model.