Skip to content

OCPBUGS-61398: fix(test): prevent nil pointer dereference in ginkgo test runner #30224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

OCPBUGS-61398: fix(test): prevent nil pointer dereference in ginkgo test runner #30224

wants to merge 1 commit into from

Conversation

bryan-cox
Copy link
Member

Add nil checks to recordTestResultInMonitor, recordTestResultInLog, and TestEnded functions to prevent segmentation faults when testRunResult is nil during error conditions like network connectivity issues.

@bryan-cox
fix(test): prevent nil pointer dereference in ginkgo test runner
6c93dfa 
Add nil checks to recordTestResultInMonitor, recordTestResultInLog, and
TestEnded functions to prevent segmentation faults when testRunResult
is nil during error conditions like network connectivity issues.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bryan-cox
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bryan-cox
Copy link
Member Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

@bryan-cox: The following commands are available to trigger required jobs:

/test e2e-aws-jenkins

/test e2e-aws-ovn-fips

/test e2e-aws-ovn-image-registry

/test e2e-aws-ovn-microshift

/test e2e-aws-ovn-microshift-serial

/test e2e-aws-ovn-serial-1of2

/test e2e-aws-ovn-serial-2of2

/test e2e-gcp-ovn

/test e2e-gcp-ovn-builds

/test e2e-gcp-ovn-image-ecosystem

/test e2e-gcp-ovn-upgrade

/test e2e-metal-ipi-ovn-ipv6

/test e2e-vsphere-ovn

/test e2e-vsphere-ovn-upi

/test images

/test lint

/test okd-scos-images

/test unit

/test verify

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-agnostic-ovn-cmd

/test e2e-aws-csi

/test e2e-aws-disruptive

/test e2e-aws-etcd-certrotation

/test e2e-aws-etcd-recovery

/test e2e-aws-ovn

/test e2e-aws-ovn-cgroupsv2

/test e2e-aws-ovn-edge-zones

/test e2e-aws-ovn-etcd-scaling

/test e2e-aws-ovn-kube-apiserver-rollout

/test e2e-aws-ovn-kubevirt

/test e2e-aws-ovn-serial-ipsec

/test e2e-aws-ovn-serial-publicnet-1of2

/test e2e-aws-ovn-serial-publicnet-2of2

/test e2e-aws-ovn-single-node

/test e2e-aws-ovn-single-node-serial

/test e2e-aws-ovn-single-node-techpreview

/test e2e-aws-ovn-single-node-techpreview-serial

/test e2e-aws-ovn-single-node-upgrade

/test e2e-aws-ovn-upgrade

/test e2e-aws-ovn-upgrade-rollback

/test e2e-aws-ovn-upi

/test e2e-aws-proxy

/test e2e-azure

/test e2e-azure-ovn-etcd-scaling

/test e2e-azure-ovn-upgrade

/test e2e-baremetalds-kubevirt

/test e2e-external-aws

/test e2e-external-aws-ccm

/test e2e-external-vsphere-ccm

/test e2e-gcp-csi

/test e2e-gcp-disruptive

/test e2e-gcp-fips-serial-1of2

/test e2e-gcp-fips-serial-2of2

/test e2e-gcp-ovn-etcd-scaling

/test e2e-gcp-ovn-rt-upgrade

/test e2e-gcp-ovn-techpreview

/test e2e-gcp-ovn-techpreview-serial-1of2

/test e2e-gcp-ovn-techpreview-serial-2of2

/test e2e-gcp-ovn-usernamespace

/test e2e-hypershift-conformance

/test e2e-metal-ipi-ovn

/test e2e-metal-ipi-ovn-bgp-virt-dualstack

/test e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview

/test e2e-metal-ipi-ovn-dualstack

/test e2e-metal-ipi-ovn-dualstack-bgp

/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw

/test e2e-metal-ipi-ovn-dualstack-local-gateway

/test e2e-metal-ipi-ovn-kube-apiserver-rollout

/test e2e-metal-ipi-serial-1of2

/test e2e-metal-ipi-serial-2of2

/test e2e-metal-ipi-serial-ovn-ipv6-1of2

/test e2e-metal-ipi-serial-ovn-ipv6-2of2

/test e2e-metal-ipi-virtualmedia

/test e2e-metal-ovn-single-node-live-iso

/test e2e-metal-ovn-single-node-with-worker-live-iso

/test e2e-metal-ovn-two-node-arbiter

/test e2e-metal-ovn-two-node-fencing

/test e2e-openstack-ovn

/test e2e-openstack-serial

/test e2e-vsphere-ovn-dualstack-primaryv6

/test e2e-vsphere-ovn-etcd-scaling

/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-main-e2e-agnostic-ovn-cmd

pull-ci-openshift-origin-main-e2e-aws-csi

pull-ci-openshift-origin-main-e2e-aws-disruptive

pull-ci-openshift-origin-main-e2e-aws-ovn

pull-ci-openshift-origin-main-e2e-aws-ovn-cgroupsv2

pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones

pull-ci-openshift-origin-main-e2e-aws-ovn-fips

pull-ci-openshift-origin-main-e2e-aws-ovn-kube-apiserver-rollout

pull-ci-openshift-origin-main-e2e-aws-ovn-microshift

pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial

pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2

pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2

pull-ci-openshift-origin-main-e2e-aws-ovn-single-node

pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-serial

pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-upgrade

pull-ci-openshift-origin-main-e2e-aws-ovn-upgrade

pull-ci-openshift-origin-main-e2e-aws-proxy

pull-ci-openshift-origin-main-e2e-azure

pull-ci-openshift-origin-main-e2e-gcp-csi

pull-ci-openshift-origin-main-e2e-gcp-ovn

pull-ci-openshift-origin-main-e2e-gcp-ovn-rt-upgrade

pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview

pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview-serial-1of2

pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview-serial-2of2

pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade

pull-ci-openshift-origin-main-e2e-hypershift-conformance

pull-ci-openshift-origin-main-e2e-metal-ipi-ovn

pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack

pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack-local-gateway

pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6

pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-kube-apiserver-rollout

pull-ci-openshift-origin-main-e2e-metal-ipi-serial-1of2

pull-ci-openshift-origin-main-e2e-metal-ipi-serial-2of2

pull-ci-openshift-origin-main-e2e-metal-ipi-serial-ovn-ipv6-1of2

pull-ci-openshift-origin-main-e2e-metal-ipi-serial-ovn-ipv6-2of2

pull-ci-openshift-origin-main-e2e-metal-ipi-virtualmedia

pull-ci-openshift-origin-main-e2e-openstack-ovn

pull-ci-openshift-origin-main-e2e-vsphere-ovn

pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi

pull-ci-openshift-origin-main-images

pull-ci-openshift-origin-main-lint

pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn

pull-ci-openshift-origin-main-okd-scos-images

pull-ci-openshift-origin-main-unit

pull-ci-openshift-origin-main-verify

pull-ci-openshift-origin-main-verify-deps

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bryan-cox
Copy link
Member Author

/payload-job periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-azure-aks-ovn-conformance

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

@bryan-cox: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-azure-aks-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/43c26830-8cec-11f0-99d4-4a7d016127ce-0

@bryan-cox bryan-cox changed the title fix(test): prevent nil pointer dereference in ginkgo test runner OCPBUGS-61398: fix(test): prevent nil pointer dereference in ginkgo test runner Sep 9, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 9, 2025
@openshift-ci-robot
Copy link

@bryan-cox: This pull request references Jira Issue OCPBUGS-61398, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add nil checks to recordTestResultInMonitor, recordTestResultInLog, and TestEnded functions to prevent segmentation faults when testRunResult is nil during error conditions like network connectivity issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Member Author

/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-azure-aks-ovn-conformance

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

@bryan-cox: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-azure-aks-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1db50ab0-8d66-11f0-8907-e695ccc5699f-0

@bryan-cox
Copy link
Member Author

/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-azure-aks-ovn-conformance

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

@bryan-cox: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-azure-aks-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/61c53f90-8db1-11f0-889f-9602327fdd96-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryan-cox @openshift-ci-robot