Skip to content

Conversation

dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Sep 8, 2025

In https://issues.redhat.com/browse/OCPBUGS-61224 we found haproxy is core dumping right before we get disruption. Scanning journals for systemd-coredump lines seems like a good idea.

Flake only for now, who knows what this might pick up initially.

Assisted-by: Cursor AI

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial September 8, 2025 18:13
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2025
Copy link

openshift-trt bot commented Sep 8, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: aab567c

  • "[sig-node] systemd should not log any core dumps to system journal" [Total: 35, Pass: 35, Fail: 0, Flake: 0]

@@ -272,7 +272,8 @@ const (
ReasonHighGeneration IntervalReason = "HighGeneration"
ReasonInvalidGeneration IntervalReason = "GenerationViolation"

ReasonEtcdBootstrap IntervalReason = "EtcdBootstrap"
ReasonEtcdBootstrap IntervalReason = "EtcdBootstrap"
ReasonProcessDumpedCore = "ProcessDumpedCore"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ReasonProcessDumpedCore = "ProcessDumpedCore"
ReasonProcessDumpedCore IntervalReason = "ProcessDumpedCore"

@dgoodwin dgoodwin force-pushed the systemd-coredump-intervals branch from aab567c to fe11f5f Compare September 9, 2025 11:58
@smg247
Copy link
Member

smg247 commented Sep 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2025
Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn fe11f5f link true /test e2e-gcp-ovn
ci/prow/e2e-gcp-ovn-techpreview fe11f5f link false /test e2e-gcp-ovn-techpreview
ci/prow/okd-scos-e2e-aws-ovn fe11f5f link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-ovn-techpreview-serial-2of2 fe11f5f link false /test e2e-gcp-ovn-techpreview-serial-2of2
ci/prow/e2e-aws-ovn-single-node-serial fe11f5f link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-hypershift-conformance fe11f5f link false /test e2e-hypershift-conformance
ci/prow/e2e-aws-ovn-cgroupsv2 fe11f5f link false /test e2e-aws-ovn-cgroupsv2
ci/prow/unit fe11f5f link true /test unit
ci/prow/e2e-gcp-ovn-techpreview-serial-1of2 fe11f5f link false /test e2e-gcp-ovn-techpreview-serial-1of2
ci/prow/e2e-aws-ovn-serial-2of2 fe11f5f link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2 fe11f5f link false /test e2e-metal-ipi-serial-ovn-ipv6-2of2
ci/prow/verify fe11f5f link true /test verify
ci/prow/e2e-metal-ipi-serial-2of2 fe11f5f link false /test e2e-metal-ipi-serial-2of2
ci/prow/e2e-openstack-ovn fe11f5f link false /test e2e-openstack-ovn
ci/prow/e2e-aws-disruptive fe11f5f link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-trt bot commented Sep 9, 2025

Job Failure Risk Analysis for sha: fe11f5f

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-disruptive IncompleteTests
Tests for this run (25) are below the historical average (424): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-hypershift-conformance Medium
[sig-sippy] infrastructure should work
This test has passed 81.48% of 54 runs on release 4.21 [Architecture:amd64 FeatureSet:default Installer:hypershift JobTier:standard Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws Procedure:none SecurityMode:default Topology:external Upgrade:none] in the last week.

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: fe11f5f

Job Name New Test Risk
pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn Medium - "Find the input image origin_scos-4.21_tools and tag it into the pipeline" is a new test, and was only seen in one job.

New tests seen in this PR at sha: fe11f5f

  • "Find the input image origin_scos-4.21_tools and tag it into the pipeline" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[Jira:"Test Framework"] should not find any systemd-coredump logs in system journal" [Total: 38, Pass: 38, Fail: 0, Flake: 0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants