Skip to content

Conversation

everettraven
Copy link
Contributor

@everettraven everettraven commented Sep 8, 2025

When we introduced the tests for the ExternalOIDC* features we didn't realize that there was a standardized approach for using community-based images in our e2e tests and configured our tests to create a Keycloak deployment using a direct reference to the quay.io/keycloak/keycloak:25.0 image to exercise the behavior of configuring an external IdP.

This PR updates the allowed community images to include the quay.io/keycloak/keycloak:25.0 image and updates our Keycloak deployment helper to pull the correct location for the keycloak image.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2025
Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the e2e-images-update Related to images used by e2e tests label Sep 8, 2025
@everettraven
Copy link
Contributor Author

/payload-job periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview

Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

@everettraven: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a3565a70-8cda-11f0-9abc-92987cd18695-0

@everettraven everettraven force-pushed the oidc/add-allowed-image branch from a389ddd to c72a2df Compare September 9, 2025 12:06
@everettraven everettraven changed the title wip: try adding keycloak to allowedImages CNTRLPLANE-945: images: add keycloak images and use them in ExternalOIDC tests Sep 9, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 9, 2025

@everettraven: This pull request references CNTRLPLANE-945 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@everettraven everettraven marked this pull request as ready for review September 9, 2025 12:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 9, 2025

@everettraven: This pull request references CNTRLPLANE-945 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

When we introduced the tests for the ExternalOIDC* features we didn't realize that there was a standardized approach for using community-based images in our e2e tests and configured our tests to create a Keycloak deployment using a direct reference to the quay.io/keycloak/keycloak:25.0 image to exercise the behavior of configuring an external IdP.

This PR updates the allowed community images to include the quay.io/keycloak/keycloak:25.0 image and updates our Keycloak deployment helper to pull the correct location for the keycloak image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@everettraven
Copy link
Contributor Author

/payload-job periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-configure-techpreview

Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

@everettraven: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-configure-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/026fe3f0-8d76-11f0-9ee3-28c4c87f7373-0

@everettraven
Copy link
Contributor Author

/payload-job periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-configure-techpreview

Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

@everettraven: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-authentication-operator-release-4.21-periodics-e2e-aws-external-oidc-configure-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5a0d0d90-8d8f-11f0-9e45-3f5441bbdf70-0

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image mirrored:

$ podman image exists quay.io/openshift/community-e2e-images:e2e-quay-io-keycloak-keycloak-25-0-rEIw9B2Zcc3L1M6k
$ echo $?
0

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2025
Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2025
@everettraven
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

@everettraven: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway c72a2df link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-aws-ovn-cgroupsv2 c72a2df link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-openstack-ovn c72a2df link false /test e2e-openstack-ovn
ci/prow/e2e-hypershift-conformance c72a2df link false /test e2e-hypershift-conformance
ci/prow/e2e-metal-ipi-ovn c72a2df link false /test e2e-metal-ipi-ovn
ci/prow/e2e-metal-ipi-serial-2of2 c72a2df link false /test e2e-metal-ipi-serial-2of2
ci/prow/e2e-metal-ipi-ovn-ipv6 c72a2df link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-ovn-dualstack c72a2df link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-ovn-single-node c72a2df link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn c72a2df link false /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-edge-zones c72a2df link false /test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-disruptive c72a2df link false /test e2e-aws-disruptive
ci/prow/e2e-gcp-ovn-techpreview-serial-1of2 c72a2df link false /test e2e-gcp-ovn-techpreview-serial-1of2
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2 c72a2df link false /test e2e-metal-ipi-serial-ovn-ipv6-2of2
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout c72a2df link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/okd-scos-e2e-aws-ovn c72a2df link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-serial-2of2 c72a2df link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-metal-ipi-serial-1of2 c72a2df link false /test e2e-metal-ipi-serial-1of2
ci/prow/e2e-agnostic-ovn-cmd c72a2df link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-metal-ipi-virtualmedia c72a2df link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-aws-ovn-kube-apiserver-rollout c72a2df link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node-serial c72a2df link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-proxy c72a2df link false /test e2e-aws-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-trt bot commented Sep 9, 2025

Job Failure Risk Analysis for sha: c72a2df

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-disruptive IncompleteTests
Tests for this run (106) are below the historical average (409): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-serial-1of2 IncompleteTests
Tests for this run (12) are below the historical average (1542): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-serial-2of2 IncompleteTests
Tests for this run (12) are below the historical average (1515): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-serial-ovn-ipv6-2of2 IncompleteTests
Tests for this run (12) are below the historical average (1505): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-openstack-ovn IncompleteTests
Tests for this run (102) are below the historical average (2393): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: c72a2df

Job Name New Test Risk
pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn Medium - "Find the input image origin_scos-4.21_tools and tag it into the pipeline" is a new test, and was only seen in one job.

New tests seen in this PR at sha: c72a2df

  • "Find the input image origin_scos-4.21_tools and tag it into the pipeline" [Total: 2, Pass: 2, Fail: 0, Flake: 0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. e2e-images-update Related to images used by e2e tests jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants