Skip to content

NO-JIRA: Miscellaneous OTE improvements #30216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

NO-JIRA: Miscellaneous OTE improvements #30216

wants to merge 4 commits into from
+364 −53

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Sep 4, 2025

  • bump OTE vendoring to pull in logging changes
  • fix source reporting in internal extension for origin
  • include additional information in ote JSON artifact

@stbenjam
vendor: bump ote to get latest changes
e351750
@stbenjam
extension: fix source in ote extension
d56a389 
origin's internal extension doesn't report source correctly; my attempt
to shadow `Source` with additional information in the in-lined
`Extension` didn't quite work the way I expected.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@stbenjam
Copy link
Member Author

stbenjam commented Sep 4, 2025

/test e2e-aws-ovn

@openshift-ci openshift-ci bot added vendor-update Touching vendor dir or related files approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 4, 2025
@stbenjam
Copy link
Member Author

stbenjam commented Sep 5, 2025

/test e2e-aws-ovn

@stbenjam
Copy link
Member Author

stbenjam commented Sep 5, 2025

/test e2e-gcp-ovn-upgrade

@stbenjam stbenjam marked this pull request as ready for review September 5, 2025 13:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025
@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial September 5, 2025 13:02
@stbenjam
Copy link
Member Author

stbenjam commented Sep 5, 2025

Example: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/30216/pull-ci-openshift-origin-main-e2e-aws-ovn/1963771632170307584/artifacts/e2e-aws-ovn/openshift-e2e-test/artifacts/junit/extension_test_results__20250905-025155.json

@stbenjam
runsuite: include more information in ote artifact
3e5d96e 
Store the ginkgo run suite options.
@smg247
Copy link
Member

smg247 commented Sep 5, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smg247, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member Author

stbenjam commented Sep 8, 2025

/verified later

@openshift-ci-robot
Copy link

@stbenjam: /verified later <@username> requires at least one GitHub @username to be specified (it can be a comma delimited list). It indicates the engineer(s) that will be performing the verification. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

In response to this:

/verified later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam stbenjam changed the title Miscellaneous OTE improvements NO-JIRA: Miscellaneous OTE improvements Sep 8, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 8, 2025
@openshift-ci-robot
Copy link

@stbenjam: This pull request explicitly references no jira issue.

In response to this:

  • bump OTE vendoring to pull in logging changes
  • fix source reporting in internal extension for origin
  • include additional information in ote JSON artifact

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam
Copy link
Member Author

stbenjam commented Sep 8, 2025

/verified skipped

@openshift-ci-robot
Copy link

@stbenjam: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

In response to this:

/verified skipped

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam
Copy link
Member Author

stbenjam commented Sep 8, 2025

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 8, 2025
@openshift-ci-robot
Copy link

@stbenjam: The verified label has been added.

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2af38a7 and 2 for PR HEAD d1a8eff in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 755c0d2 and 1 for PR HEAD d1a8eff in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 755c0d2 and 2 for PR HEAD d1a8eff in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-csi d1a8eff link false /test e2e-aws-csi
ci/prow/e2e-metal-ipi-virtualmedia d1a8eff link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway d1a8eff link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/okd-scos-e2e-aws-ovn d1a8eff link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout d1a8eff link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node-serial d1a8eff link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-edge-zones d1a8eff link false /test e2e-aws-ovn-edge-zones
ci/prow/e2e-openstack-ovn d1a8eff link false /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-dualstack d1a8eff link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-disruptive d1a8eff link false /test e2e-aws-disruptive
ci/prow/e2e-aws-ovn-single-node-upgrade d1a8eff link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 d1a8eff link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-serial-2of2 d1a8eff link true /test e2e-aws-ovn-serial-2of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bc0ce7e and 1 for PR HEAD d1a8eff in total

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees

@smg247 smg247

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. vendor-update Touching vendor dir or related files verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stbenjam @smg247 @openshift-ci-robot @openshift-merge-robot