-
Notifications
You must be signed in to change notification settings - Fork 4.7k
OCPBUGS-60593: Skip oauth test for external control plane topology #30200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance-serial |
@dinhxuanvu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/74f7ed50-8803-11f0-8764-482860b01723-0 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dinhxuanvu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dinhxuanvu: This pull request references Jira Issue OCPBUGS-60593, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@dinhxuanvu: This pull request references Jira Issue OCPBUGS-60593, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@everettraven Hey Bryce, I think this PR is good to go unless you have any further comments. PTAL. Thanks. |
ef4a4dd
to
7338129
Compare
@dinhxuanvu: This pull request references Jira Issue OCPBUGS-60593, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
For HyperShift, the control plane topology is external as control plane components are not deployed in management cluster. As a result, the oauth operator is unavailable and this test should be skipped. Moving the topology check to the top before the cluster auth operator check will ensure this test is skipped in external topology mode. Signed-off-by: Vu Dinh <[email protected]>
7338129
to
02635e1
Compare
@dinhxuanvu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Job Failure Risk Analysis for sha: 02635e1
|
For HyperShift, the control plane topology is external as control
plane components are not deployed in management cluster. As a result,
the oauth operator is unavailable and this test should be skipped.
Moving the topology check to the top before the cluster auth operator
check will ensure this test is skipped in external topology mode.