Skip to content

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Sep 3, 2018

Cherry pick of kubernetes/kubernetes#68001 on release-3.11.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sttts
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: childsb

If they are not already assigned, you can assign the PR to them by writing /assign @childsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 3, 2018
@sttts sttts closed this Sep 3, 2018
@sttts sttts deleted the sttts-68001-3.11 branch September 3, 2018 12:23
@openshift-ci-robot
Copy link

@sttts: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/gcp dad8b4b link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Sep 4, 2018

@sttts why did this one close?

@sttts
Copy link
Contributor Author

sttts commented Sep 4, 2018

Superseeded by #20848.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants