Skip to content

Update apiVersion in migrate-network-policy.sh, add comments #19977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2018
Merged

Update apiVersion in migrate-network-policy.sh, add comments #19977

merged 1 commit into from
Jul 26, 2018

Conversation

danwinship
Copy link
Contributor

Just noticed that the migration script still refers to NetworkPolicy by its old apiVersion.

The current version of the script still works, but we need to update it at some point.

Also added some comments while I was there. (I referred to the docs by titles rather than linking directly to a URL so that it's not linking to any specific product [Origin/OCP/Dedicated] or version.)

@danwinship danwinship added component/networking sig/networking kind/documentation Categorizes issue or PR as related to documentation. labels Jun 12, 2018
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 12, 2018
@danwinship danwinship requested review from knobunc and dcbw June 12, 2018 13:05
knobunc
knobunc approved these changes Jun 12, 2018
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for adding the clear comment to the top explaining it.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2018
@knobunc
Copy link
Contributor

knobunc commented Jun 12, 2018

/assign @derekwaynecarr
Derek, this is safe to go into 3.10 because it is not shipped with the product, but instead linked to by our docs as a migration aide.

@bparees bparees removed their request for review June 12, 2018 13:42
dcbw
dcbw approved these changes Jun 12, 2018
View reviewed changes
Copy link
Contributor

@dcbw dcbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pravisankar
pravisankar approved these changes Jun 12, 2018
View reviewed changes
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhgupta
Copy link
Member

@derekwaynecarr @deads2k Can someone please approve this PR to get this merged? We are trying to pull this script in the Dedicated clusters and would like to pick up this change from the merged version rather than the PR

@knobunc
Copy link
Contributor

knobunc commented Jul 19, 2018

@deads2k @derekwaynecarr Please approve!

@danwinship
Copy link
Contributor Author

/retest

@deads2k
Copy link
Contributor

deads2k commented Jul 23, 2018

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@danwinship
Copy link
Contributor Author

/restest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@danwinship
Copy link
Contributor Author

/retest

@derekwaynecarr
Copy link
Member

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, dcbw, deads2k, derekwaynecarr, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [deads2k,derekwaynecarr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@danwinship
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit dbdc144 into openshift:master Jul 26, 2018
@danwinship danwinship deleted the update-migration-script branch January 31, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc knobunc approved these changes

@soltysh soltysh Awaiting requested review from soltysh

+2 more reviewers

@pravisankar pravisankar pravisankar approved these changes

@dcbw dcbw dcbw approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@derekwaynecarr derekwaynecarr

@knobunc knobunc

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/networking kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. sig/networking size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@danwinship @knobunc @abhgupta @deads2k @openshift-bot @derekwaynecarr @openshift-ci-robot @pravisankar @dcbw @openshift-merge-robot