Skip to content

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Apr 9, 2018

Follow up to #19137
Fixes #13857

Mirrors kube switch in 1.10

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2018
@liggitt liggitt mentioned this pull request Apr 9, 2018
51 tasks
@liggitt
Copy link
Contributor Author

liggitt commented Apr 10, 2018

/retest

2 similar comments
@liggitt
Copy link
Contributor Author

liggitt commented Apr 11, 2018

/retest

@liggitt
Copy link
Contributor Author

liggitt commented Apr 11, 2018

/retest

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor

soltysh commented Apr 12, 2018

/retest

@soltysh
Copy link
Contributor

soltysh commented Apr 12, 2018

@sdodson fyi, we'll need to run storage upgrade for all resources, although iirc we already are, aren't we?

@sdodson
Copy link
Member

sdodson commented Apr 12, 2018

@soltysh yes, every upgrade gets a storage migrate prior to and after the API server is updated.
https://github.com/openshift/openshift-ansible/blob/master/playbooks/openshift-master/private/upgrade.yml#L26

https://github.com/openshift/openshift-ansible/blob/master/playbooks/openshift-master/private/upgrade.yml#L244

@openshift-merge-robot openshift-merge-robot merged commit ca2c38c into openshift:master Apr 12, 2018
@liggitt liggitt deleted the apps-storage branch April 13, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/post-rebase lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants