-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Updating external examples #18970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating external examples #18970
Conversation
Updating the external examples Needed for pull request #18708
@bparees ptal |
not sure why that would be the case since you're updating the imagestreams to v3.10 in your PR, but /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, coreydaley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@bparees it does seem weird, but looking at the results of the two failed tests (that I wrote for this pr), that is what i have seen cause that result, as it did locally when the library pr overwrote my local changes when i rebased. |
/retest |
2 similar comments
/retest |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest Please review the full test history for this PR and help us cut down flakes. |
Automatic merge from submit-queue. |
@coreydaley: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Updating the external examples
Needed for pull request #18708