Skip to content

Conversation

coreydaley
Copy link

Updating the external examples
Needed for pull request #18708

Updating the external examples
Needed for pull request #18708
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 13, 2018
@coreydaley
Copy link
Author

@bparees ptal
It looks like the last library updates are overwriting the reference to the jenkins 3.10 image tag in my pr, and causing my tests to fail.

@bparees
Copy link
Contributor

bparees commented Mar 13, 2018

It looks like the last library updates are overwriting the reference to the jenkins 3.10 image tag in my pr, and causing my tests to fail.

not sure why that would be the case since you're updating the imagestreams to v3.10 in your PR, but

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2018
@coreydaley
Copy link
Author

/retest

@coreydaley
Copy link
Author

@bparees it does seem weird, but looking at the results of the two failed tests (that I wrote for this pr), that is what i have seen cause that result, as it did locally when the library pr overwrote my local changes when i rebased.

@coreydaley
Copy link
Author

/retest

2 similar comments
@coreydaley
Copy link
Author

/retest

@coreydaley
Copy link
Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit c7e8dd2 into openshift:master Mar 13, 2018
@openshift-ci-robot
Copy link

@coreydaley: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp 2db75ae link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants