Minor fixup to auto egress IP deletion fix #18866
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to #18720. That added a missing
node.assignedIPs.Delete(egressIP)
todeleteEgressIP
, but it added it in the wrong place, inside theif node.nodeIP == eip.localIP
check, so only the node hosting the egress IP would clean things up properly and the other nodes would still stay broken. The test added in #18720 didn't pick this up because it only tested add-remove-add in the egress-on-local-node case, not the remote case.(This is fixed in master as part of the larger changes in #18808, but that's not going to be backported immediately, whereas this could be.)
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1547899