Skip to content

Conversation

danwinship
Copy link
Contributor

@danwinship danwinship commented Mar 6, 2018

Fix to #18720. That added a missing node.assignedIPs.Delete(egressIP) to deleteEgressIP, but it added it in the wrong place, inside the if node.nodeIP == eip.localIP check, so only the node hosting the egress IP would clean things up properly and the other nodes would still stay broken. The test added in #18720 didn't pick this up because it only tested add-remove-add in the egress-on-local-node case, not the remote case.

(This is fixed in master as part of the larger changes in #18808, but that's not going to be backported immediately, whereas this could be.)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1547899

@danwinship danwinship added kind/bug Categorizes issue or PR as related to a bug. component/networking sig/networking labels Mar 6, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2018
@openshift-ci-robot openshift-ci-robot requested a review from dcbw March 6, 2018 20:27
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 6, 2018
@danwinship danwinship force-pushed the minor-egressip-fix-39 branch from b5b14fa to d941703 Compare March 6, 2018 20:31
@danwinship danwinship force-pushed the minor-egressip-fix-39 branch from d941703 to 372e914 Compare March 6, 2018 20:31
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2018

@danwinship: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cmd 372e914 link /test cmd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danwinship
Copy link
Contributor Author

This didn't merge in time and will eventually be fixed by #18808 instead

@danwinship danwinship closed this Mar 7, 2018
@danwinship danwinship deleted the minor-egressip-fix-39 branch July 20, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/networking kind/bug Categorizes issue or PR as related to a bug. sig/networking size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants