Add origin types kubectl scheme #17885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
the
approved
openshift-ci-robot
requested review from
adelton,
bparees,
enj,
gabemontero,
jim-minter,
liggitt,
mfojtik,
miminar,
mrogers950,
pweil-,
rajatchopra,
simo5,
smarterclayton and
soltysh
openshift-ci-robot
added
the
size/L
openshift-merge-robot
added
needs-rebase
… legacyscheme so our types can be handled
deads2k
force-pushed
the
api-14-legacyinstall
branch
from
67aeda4 to
ec8902b
Compare
openshift-merge-robot
removed
the
needs-rebase
juanvallejo
approved these changes
Dec 19, 2017
|
/retest |
|
/retest |
|
Got lgtm from sttts via irc |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 17859, 17885). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17793
Builds on #17815
/assign sttts
/assign juanvallejo
This centralizes the legacy install function. The next logical step is going to require that we start plumbing particular schemes or build individual schemes. I looked at doing that here, but it appears we have some 500 hits just for scheme usage and I haven't decided the optimal solution for something like our graph yet.