OVS parsing improvements #17878
Merged
OVS parsing improvements #17878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
Rename "ParseForDelete" to "ParseForFilter" (since it's about parsing flow descriptions that are being used as filters, not specifically about deleting), and fix up the logic around default values in ParseForAdd vs ParseForFilter. (Among other things, this fixes the code so that you can match on table=0, priority=0, or cookie=0.)
danwinship
force-pushed
the
ovs-parsing
branch
from
5742d7e to
ae697ea
Compare
|
Nice |
|
/retest |
getPodDetailsBySandboxID() was written to have the list of flows passed into it, for ease of testing. But that requires the caller to know what flows it is looking for, and anyway, ovsController is already mockable anyway so we can test the function just as easily as an ovsController method.
danwinship
force-pushed
the
ovs-parsing
branch
from
ae697ea to
e32c9c3
Compare
|
/retest |
1 similar comment
|
/retest |
|
@dcbw PTAL |
|
/approve but not reviewed |
openshift-ci-robot
added
the
approved
pravisankar
approved these changes
Jan 22, 2018
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, pravisankar, smarterclayton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The more-complicated version of #17313. This takes advantage of the fact that "ovs-ofctl dump-flows" lets you pass a filter, so rather than getting back the whole list of flows and parsing each one, we can just ask for a much smaller set of flows to begin with.
In particular:
DumpFlows("table=%d", ruleVersionTable)and get back only the single flow we're looking forDumpFlows("table=20,arp")and only get back the flows that might be the one we're looking for. (You can't match on theactionsfield, so there's no way to request only the flow that has the specificnotethat we're looking for. We could store the first 4 bytes of the sandbox ID in the cookie and then add that to the filter, I guess, but this code doesn't get run much anyway...)