Skip to content

Conversation

php-coder
Copy link
Contributor

PTAL @liggitt @pweil- @openshift/sig-security

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Nov 29, 2017
@simo5
Copy link
Contributor

simo5 commented Nov 29, 2017

Pr is ok, but there are still a couple of comments upstream, will LGTM once merged in kube

@liggitt
Copy link
Contributor

liggitt commented Nov 30, 2017

/lgtm
/test

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, php-coder

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2017
@simo5 simo5 added the kind/bug Categorizes issue or PR as related to a bug. label Nov 30, 2017
@php-coder
Copy link
Contributor Author

/retest

@php-coder
Copy link
Contributor Author

Test flake #17263
/test extended_conformance_install

@php-coder
Copy link
Contributor Author

Test flake #17574
/test cmd

@php-coder
Copy link
Contributor Author

/cherrypick release-3.7

@openshift-cherrypick-robot

@php-coder: @php-coder once the present PR merges, I will cherry-pick it on top of release-3.7 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@php-coder
Copy link
Contributor Author

/cherrypick release-3.6

@openshift-cherrypick-robot

@php-coder: @php-coder once the present PR merges, I will cherry-pick it on top of release-3.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17536, 17512).

@openshift-merge-robot openshift-merge-robot merged commit d1a9074 into openshift:master Dec 5, 2017
@openshift-cherrypick-robot

@php-coder: PR 17512 failed to apply on top of branch "release-3.7": exit status 128

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@php-coder php-coder deleted the fail_non_root_verification branch December 5, 2017 11:00
@0xmichalis
Copy link
Contributor

/cherrypick release-3.7

@openshift-cherrypick-robot

@Kargakis: #17512 failed to apply on top of branch "release-3.7": exit status 128

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0xmichalis
Copy link
Contributor

/cherrypick release-3.7

@openshift-cherrypick-robot

@Kargakis: new pull request created: #17701

In response to this:

/cherrypick release-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@php-coder
Copy link
Contributor Author

/cherrypick release-3.8

@openshift-cherrypick-robot

@php-coder: new pull request created: #17702

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eparis added a commit that referenced this pull request Dec 14, 2017
…-17512-to-release-3.8

Automated cherry-pick of #17512 on release-3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants