Old routers may not have permission to do SAR checks for metrics #17268
Conversation
Fallback to the old unauthorized status code. Do the same for the authentication and authorization checks, although authorization should be forbidden.
openshift-ci-robot
added
the
size/S
openshift-merge-robot
added
the
approved
| // older routers will not have permission to check token access review, so treat this | ||
| // as an authorization denied if so | ||
| if !ok || errors.IsUnauthorized(err) { | ||
| glog.V(5).Infof("Unable to authenticate: %v", err) |
There was a problem hiding this comment.
It might show nothing in case of err==nil and !ok, but it's harmless.
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@smarterclayton: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| // as an authorization denied if so | ||
| if !ok || errors.IsUnauthorized(err) { | ||
| glog.V(5).Infof("Unable to authenticate: %v", err) | ||
| http.Error(w, "Unable to authenticate due to an error", http.StatusUnauthorized) |
There was a problem hiding this comment.
Do we want to show that string to the end user?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knobunc, rajatchopra, smarterclayton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Going to manually merge this one to unblock us in the AMI. |
Fallback to the old unauthorized status code. Do the same for the
authentication and authorization checks, although authorization should
be forbidden.
Contains #17259