UPSTREAM: 54828: trigger endpoint update on pod deletion #17120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
openshift-merge-robot
added
the
vendor-update
|
/assign @sjenning |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, joelsmith The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 17089, 17120). |
openshift-merge-robot
added a commit
that referenced
this pull request
Nov 2, 2017
Automatic merge from submit-queue. [stage] UPSTREAM: 54828: trigger endpoint update on pod deletion xref #17120
openshift-merge-robot
added a commit
that referenced
this pull request
Nov 3, 2017
Automatic merge from submit-queue. UPSTREAM: 54828: trigger endpoint update on pod deletion xref #17120
openshift-merge-robot
added a commit
that referenced
this pull request
Nov 29, 2017
Automatic merge from submit-queue (batch tested with PRs 17476, 17143, 15115, 17094, 17500). fix basename: illegal option -- b issue with upstream filenames starting with - issue: ``` $ git branch -vv * devel 3ea2451 Merge pull request #17120 from joelsmith/master master 3ae4430 [origin/master] fix basename: illegal option -- b issue with upstream filenames starting with - xiaods at XiaoTommydeMacBook-Pro in ~/go/src/github.com/openshift/origin on devel* $ export PATH="${PATH}:$( source hack/lib/init.sh; echo "${OS_OUTPUT_BINPATH}/$( os::build::host_platform )/" )" basename: illegal option -- b usage: basename string [suffix] basename [-a] [-s suffix] string [...] ``` caused by : The -- (dash dash) stops basename from processing any options in the argument. Always quote $0 in case there are spaces in the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref kubernetes/kubernetes#54828