-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix remaining field selectors #16327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-robot
merged 2 commits into
openshift:master
from
deads2k:api-07-fieldselector
Sep 16, 2017
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,17 @@ | ||
| package authorization | ||
|
|
||
| import "k8s.io/apimachinery/pkg/fields" | ||
| import ( | ||
| "fmt" | ||
|
|
||
| // PolicyBindingToSelectableFields returns a label set that represents the object | ||
| // changes to the returned keys require registering conversions for existing versions using Scheme.AddFieldLabelConversionFunc | ||
| func PolicyBindingToSelectableFields(policyBinding *PolicyBinding) fields.Set { | ||
| return fields.Set{ | ||
| "metadata.name": policyBinding.Name, | ||
| "metadata.namespace": policyBinding.Namespace, | ||
| "policyRef.namespace": policyBinding.PolicyRef.Namespace, | ||
| "k8s.io/apimachinery/pkg/fields" | ||
| runtime "k8s.io/apimachinery/pkg/runtime" | ||
| ) | ||
|
|
||
| func PolicyBindingFieldSelector(obj runtime.Object, fieldSet fields.Set) error { | ||
| policyBinding, ok := obj.(*PolicyBinding) | ||
| if !ok { | ||
| return fmt.Errorf("%T not a PolicyBinding", obj) | ||
| } | ||
| fieldSet["policyRef.namespace"] = policyBinding.PolicyRef.Namespace | ||
| return nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,19 @@ | ||
| package build | ||
|
|
||
| import "k8s.io/apimachinery/pkg/fields" | ||
|
|
||
| // BuildToSelectableFields returns a label set that represents the object | ||
| // changes to the returned keys require registering conversions for existing versions using Scheme.AddFieldLabelConversionFunc | ||
| func BuildToSelectableFields(build *Build) fields.Set { | ||
| return fields.Set{ | ||
| "metadata.name": build.Name, | ||
| "metadata.namespace": build.Namespace, | ||
| "status": string(build.Status.Phase), | ||
| "podName": GetBuildPodName(build), | ||
| import ( | ||
| "fmt" | ||
|
|
||
| "k8s.io/apimachinery/pkg/fields" | ||
| runtime "k8s.io/apimachinery/pkg/runtime" | ||
| ) | ||
|
|
||
| func BuildFieldSelector(obj runtime.Object, fieldSet fields.Set) error { | ||
| build, ok := obj.(*Build) | ||
| if !ok { | ||
| return fmt.Errorf("%T not a Build", obj) | ||
| } | ||
| fieldSet["status"] = string(build.Status.Phase) | ||
| fieldSet["podName"] = GetBuildPodName(build) | ||
|
|
||
| return nil | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have any custom field selectors. Yet. I'm placing the skeleton here so people can more easily figure out what to do. This isn't really obvious.