Updating docker --build-arg test due to docker code change #16212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
@openshift/devex ptal |
|
/retest |
csrwng
reviewed
Sep 7, 2017
test/extended/builds/start.go
Outdated
| g.By("starting the build with --build-arg flag") | ||
| br, _ := exutil.StartBuildAndWait(oc, "sample-build-docker-args", "--build-arg=bar=foo") | ||
| br.AssertFailure() | ||
| br.AssertSuccess() | ||
| buildLog, err := br.Logs() | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| g.By("verifying the build failed due to Docker.") |
There was a problem hiding this comment.
s/failed/completed with a warning/
There was a problem hiding this comment.
doh, updated the wrong spot, just a sec
There was a problem hiding this comment.
ok, this time i really updated it
|
/unassign @knobunc |
Docker changed the error for a non-existent --build-arg to a warning and changed the text of the message slightly, breaking one of our tests. Docker change: moby/moby@f150f42 Fixes: #16197
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, coreydaley The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
Automatic merge from submit-queue (batch tested with PRs 16202, 16198, 16212) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker changed the error for a non-existent --build-arg to a warning
and changed the text of the message slightly, breaking one of our tests.
Docker change: moby/moby@f150f42
Fixes: #16197