Skip to content

UPSTREAM: 49724: skip WaitForAttachAndMount for terminated pods in syncPod #15534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2017
Merged

UPSTREAM: 49724: skip WaitForAttachAndMount for terminated pods in syncPod #15534

merged 1 commit into from
Aug 27, 2017

Conversation

sjenning
Copy link
Contributor

master PR #15533

This can wait for 3.6.1

@derekwaynecarr

@openshift-merge-robot openshift-merge-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2017
@smarterclayton smarterclayton modified the milestone: 3.6.x Jul 28, 2017
@openshift-merge-robot openshift-merge-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@stevekuznetsov
Copy link
Contributor

/test end_to_end

@sjenning
Copy link
Contributor Author

sjenning commented Aug 2, 2017

@stevekuznetsov I hit

+ hack/env make build-router-e2e-test
[INFO] Pulling the openshift/origin-release:golang-1.7 image to update it...
Trying to pull repository registry.access.redhat.com/openshift/origin-release ... 
Trying to pull repository docker.io/openshift/origin-release ... 
golang-1.7: Pulling from docker.io/openshift/origin-release
Digest: sha256:9dbd5afabca198001e9cae62eaca8646248770fe5a9e10f67baab034ab44309b
make: *** No rule to make target `build-router-e2e-test'.  Stop.

Doesn't seem like that would be a flake but I'll do a retest in case it was or has been fixed in the meantime.

/test end_to_end

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Aug 2, 2017 •
edited
Loading

Ah, crap. This branch needs get the changes backported @deads2k

@sjenning
Copy link
Contributor Author

/retest

@derekwaynecarr
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2017
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@sjenning
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sjenning
Copy link
Contributor Author

flake #15941

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 50ec04d into openshift:release-3.6 Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v3.6
Development

Successfully merging this pull request may close these issues.
7 participants
@sjenning @stevekuznetsov @derekwaynecarr @openshift-merge-robot @openshift-bot @smarterclayton @openshift-ci-robot