API docs wrong for BuildConfig instantiate

[jimmidyson]

Docs at https://docs.openshift.org/latest/rest_api/openshift_v1.html#create-instantiate-of-a-buildrequest say the response is a v1.BuildRequest, whereas it really is a v1.Build.

[bparees]

@smarterclayton how do we fix the generated swagger doc? not clear to me how it's determining the return type.

this doc is also wrong:
https://docs.openshift.org/latest/rest_api/openshift_v1.html#create-a-template

guessing that swagger just assumes POST operations are creates that return the type you posted.

[smarterclayton]

We'd have to fix api registration in Kube and have additional info defined
on the Storage classes (of which there are a few examples).

On Mon, Apr 4, 2016 at 12:48 PM, Ben Parees notifications@github.com
wrote:

@smarterclayton https://github.com/smarterclayton how do we fix the
generated swagger doc? not clear to me how it's determining the return type.

this doc is also wrong:

https://docs.openshift.org/latest/rest_api/openshift_v1.html#create-a-template

guessing that swagger just assumes POST operations are creates that return
the type you posted.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8345 (comment)

[bparees]

@smarterclayton is there an upstream issue for this?

[smarterclayton]

Not today

On Mon, Apr 4, 2016 at 4:09 PM, Ben Parees notifications@github.com wrote:

@smarterclayton https://github.com/smarterclayton is there an upstream
issue for this?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8345 (comment)

[php-coder]

Any news on that?

I've just found it because https://docs.openshift.org/latest/rest_api/kubernetes_v1.html is talking about SCC (but it shouldn't) while https://docs.openshift.org/latest/rest_api/openshift_v1.html misses SCC stuff.

[bparees]

@jim-minter in your recent exploration of the api doc did you turn up anything that has changed on this?

[jim-minter]

@bparees https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/staging/src/k8s.io/apiserver/pkg/registry/rest/rest.go#L310-L320 almost does the trick; will work on it.