Skip to content

Commit 6cc848c

Browse files
juanvallejodeads2k
authored andcommitted
call Internal() builder param
1 parent ee9ba1a commit 6cc848c

29 files changed

+43
-14
lines changed

pkg/api/graph/test/runtimeobject_nodebuilder.go

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ import (
55
"path/filepath"
66
"reflect"
77

8+
"k8s.io/apimachinery/pkg/api/meta"
9+
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
810
"k8s.io/apimachinery/pkg/runtime"
9-
"k8s.io/kubernetes/pkg/api/legacyscheme"
11+
kapi "k8s.io/kubernetes/pkg/api"
1012
"k8s.io/kubernetes/pkg/apis/autoscaling"
11-
kapi "k8s.io/kubernetes/pkg/apis/core"
1213
"k8s.io/kubernetes/pkg/kubectl/categories"
1314
"k8s.io/kubernetes/pkg/kubectl/resource"
14-
"k8s.io/kubernetes/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
1515

1616
osgraph "github.com/openshift/origin/pkg/api/graph"
1717
_ "github.com/openshift/origin/pkg/api/install"
@@ -131,25 +131,26 @@ func BuildGraph(path string) (osgraph.Graph, []runtime.Object, error) {
131131
return g, objs, err
132132
}
133133

134-
mapper := legacyscheme.Registry.RESTMapper()
134+
mapper := kapi.Registry.RESTMapper()
135+
typer := kapi.Scheme
136+
clientMapper := resource.ClientMapperFunc(func(mapping *meta.RESTMapping) (resource.RESTClient, error) {
137+
return nil, nil
138+
})
135139

136-
builder := resource.NewBuilder(
140+
r := resource.NewBuilder(
137141
&resource.Mapper{
138142
RESTMapper: mapper,
139-
ObjectTyper: legacyscheme.Scheme,
140-
ClientMapper: resource.DisabledClientForMapping{},
141-
Decoder: legacyscheme.Codecs.UniversalDecoder(),
143+
ObjectTyper: typer,
144+
ClientMapper: clientMapper,
145+
Decoder: kapi.Codecs.UniversalDecoder(),
142146
},
143147
&resource.Mapper{
144148
RESTMapper: mapper,
145-
ObjectTyper: legacyscheme.Scheme,
146-
ClientMapper: resource.DisabledClientForMapping{},
149+
ObjectTyper: typer,
150+
ClientMapper: clientMapper,
147151
Decoder: unstructured.UnstructuredJSONScheme,
148152
},
149-
categories.SimpleCategoryExpander{},
150-
)
151-
152-
r := builder.
153+
categories.SimpleCategoryExpander{}).
153154
Internal().
154155
FilenameParam(false, &resource.FilenameOptions{Recursive: false, Filenames: []string{abspath}}).
155156
Flatten().

pkg/oc/admin/migrate/migrator.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,7 @@ func (o *ResourceOptions) Complete(f *clientcmd.Factory, c *cobra.Command) error
218218
}
219219

220220
o.Builder = f.NewBuilder().
221+
Internal().
221222
AllNamespaces(allNamespaces).
222223
FilenameParam(false, &resource.FilenameOptions{Recursive: false, Filenames: o.Filenames}).
223224
ContinueOnError().

pkg/oc/admin/network/project_options.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ func (p *ProjectOptions) GetProjects() ([]*projectapi.Project, error) {
108108
}
109109

110110
r := p.Builder.
111+
Internal().
111112
ContinueOnError().
112113
NamespaceParam(p.DefaultNamespace).
113114
LabelSelectorParam(p.Selector).

pkg/oc/admin/node/node_options.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ func (n *NodeOptions) GetNodes() ([]*kapi.Node, error) {
135135
}
136136

137137
r := n.Builder.
138+
Internal().
138139
ContinueOnError().
139140
NamespaceParam(n.DefaultNamespace).
140141
LabelSelectorParam(n.Selector).

pkg/oc/admin/policy/review.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ func (o *sccReviewOptions) Complete(f *clientcmd.Factory, args []string, cmd *co
129129

130130
func (o *sccReviewOptions) Run(args []string) error {
131131
r := o.builder.
132+
Internal().
132133
NamespaceParam(o.namespace).
133134
FilenameParam(o.enforceNamespace, &o.FilenameOptions).
134135
ResourceTypeOrNameArgs(true, args...).

pkg/oc/admin/policy/subject_review.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ func (o *sccSubjectReviewOptions) Run(args []string) error {
134134
userOrSA = o.serviceAccount
135135
}
136136
r := o.builder.
137+
Internal().
137138
NamespaceParam(o.namespace).
138139
FilenameParam(o.enforceNamespace, &o.FilenameOptions).
139140
ResourceTypeOrNameArgs(true, args...).

pkg/oc/bootstrap/docker/openshift/import.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ func ImportObjects(f *clientcmd.Factory, ns, location string) error {
2525
}
2626
glog.V(8).Infof("Importing data:\n%s\n", string(data))
2727
r := f.NewBuilder().
28+
Internal().
2829
Schema(schema).
2930
ContinueOnError().
3031
NamespaceParam(ns).

pkg/oc/cli/cmd/debug.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,7 @@ func (o *DebugOptions) Complete(cmd *cobra.Command, f *clientcmd.Factory, args [
223223

224224
mapper, _ := f.Object()
225225
b := f.NewBuilder().
226+
Internal().
226227
NamespaceParam(cmdNamespace).DefaultNamespace().
227228
SingleResourceType().
228229
ResourceNames("pods", resources...).

pkg/oc/cli/cmd/deploy.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ func (o DeployOptions) Validate() error {
197197

198198
func (o DeployOptions) RunDeploy() error {
199199
r := o.builder.
200+
Internal().
200201
NamespaceParam(o.namespace).
201202
ResourceNames("deploymentconfigs", o.deploymentConfigName).
202203
SingleResourceType().

pkg/oc/cli/cmd/export.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ func RunExport(f *clientcmd.Factory, exporter Exporter, in io.Reader, out io.Wri
111111
}
112112

113113
b := f.NewBuilder().
114+
Internal().
114115
Unstructured().
115116
NamespaceParam(cmdNamespace).DefaultNamespace().AllNamespaces(allNamespaces).
116117
FilenameParam(explicit, &resource.FilenameOptions{Recursive: false, Filenames: filenames}).

0 commit comments

Comments
 (0)