Skip to content

Commit ee9ba1a

Browse files
juanvallejodeads2k
authored andcommitted
first round of fixes for test-cmd
1 parent 9292a8c commit ee9ba1a

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

pkg/oc/cli/cmd/set/env.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,7 @@ func (o *EnvOptions) RunEnv(f *clientcmd.Factory) error {
227227

228228
if len(o.From) != 0 {
229229
b := f.NewBuilder().
230+
Internal().
230231
LocalParam(o.Local).
231232
ContinueOnError().
232233
NamespaceParam(cmdNamespace).DefaultNamespace().
@@ -290,6 +291,7 @@ func (o *EnvOptions) RunEnv(f *clientcmd.Factory) error {
290291
}
291292

292293
b := f.NewBuilder().
294+
Internal().
293295
LocalParam(o.Local).
294296
ContinueOnError().
295297
NamespaceParam(cmdNamespace).DefaultNamespace().

pkg/oc/experimental/config/patch.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ func NewCmdPatch(name, fullName string, f *clientcmd.Factory, out io.Writer) *co
6767
cmd.Flags().StringVarP(&o.Patch, "patch", "p", "", "The patch to be applied to the resource JSON file.")
6868
cmd.MarkFlagRequired("patch")
6969
cmd.Flags().String("type", "strategic", fmt.Sprintf("The type of patch being provided; one of %v", sets.StringKeySet(patchTypes).List()))
70+
cmdutil.AddPrinterFlags(cmd)
7071

7172
return cmd
7273
}
@@ -134,6 +135,7 @@ func (o *PatchOptions) RunPatch() error {
134135
}
135136

136137
r := o.Builder.
138+
Internal().
137139
FilenameParam(false, &resource.FilenameOptions{Recursive: false, Filenames: []string{o.Filename}}).
138140
Flatten().
139141
Do()

tools/etcdhelper/etcdhelper.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
"time"
1212

1313
jsonserializer "k8s.io/apimachinery/pkg/runtime/serializer/json"
14-
api "k8s.io/kubernetes/pkg/apis/core"
14+
"k8s.io/kubernetes/pkg/kubectl/scheme"
1515

1616
"github.com/coreos/etcd/clientv3"
1717
"github.com/coreos/etcd/pkg/transport"
@@ -24,7 +24,7 @@ import (
2424
)
2525

2626
func init() {
27-
apiregistration.Install(api.GroupFactoryRegistry, api.Registry, api.Scheme)
27+
apiregistration.Install(scheme.GroupFactoryRegistry, scheme.Registry, scheme.Scheme)
2828
}
2929

3030
func main() {
@@ -122,8 +122,8 @@ func getKey(client *clientv3.Client, key string) error {
122122
return err
123123
}
124124

125-
decoder := api.Codecs.UniversalDeserializer()
126-
encoder := jsonserializer.NewSerializer(jsonserializer.DefaultMetaFactory, api.Scheme, api.Scheme, true)
125+
decoder := scheme.Codecs.UniversalDeserializer()
126+
encoder := jsonserializer.NewSerializer(jsonserializer.DefaultMetaFactory, scheme.Scheme, scheme.Scheme, true)
127127

128128
for _, kv := range resp.Kvs {
129129
obj, gvk, err := decoder.Decode(kv.Value, nil, nil)
@@ -149,8 +149,8 @@ func dump(client *clientv3.Client) error {
149149
}
150150

151151
kvData := []etcd3kv{}
152-
decoder := api.Codecs.UniversalDeserializer()
153-
encoder := jsonserializer.NewSerializer(jsonserializer.DefaultMetaFactory, api.Scheme, api.Scheme, false)
152+
decoder := scheme.Codecs.UniversalDeserializer()
153+
encoder := jsonserializer.NewSerializer(jsonserializer.DefaultMetaFactory, scheme.Scheme, scheme.Scheme, false)
154154
objJSON := &bytes.Buffer{}
155155

156156
for _, kv := range response.Kvs {

0 commit comments

Comments
 (0)