Removing layout.attrs to reduce dependencies #2860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/XL
|
/assign @sg00dwin |
|
@TheRealJon FYI, this removes the layout.attrs dependency (which was bower only) |
sg00dwin
reviewed
Feb 28, 2018
| @@ -35,12 +35,9 @@ | |||
| margin-top: 15px; | |||
| } | |||
| .pod-template { | |||
| // so that .word-break() on children works | |||
| [flex] { | |||
| min-width: 0; | |||
There was a problem hiding this comment.
wouldn't we need to keep min-width: 0 on .pod-template?
There was a problem hiding this comment.
Yep. It moved to line 53.
sg00dwin
reviewed
Feb 28, 2018
| @@ -30,7 +30,7 @@ | |||
| </div> | |||
| <div class="pipeline"> | |||
| <div class="pipeline-stage" ng-repeat="stage in jenkinsStatus.stages track by stage.id"> | |||
| <div column class="pipeline-stage-column"> | |||
| <div class="pipeline-stage-column"> | |||
There was a problem hiding this comment.
Shouldn't there be a .pipeline-stage-column rule with flex-direction:column; display:flex since it was removed from the markup?
There was a problem hiding this comment.
To be completely parallel with what was there, yes. But a div displays block by default, and that renders the same way as flex/column, so I opted to remove it for less code.
rhamilto
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
sg00dwin
approved these changes
Mar 1, 2018
|
/lgtm |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes #2614 by eliminating the three column layout for desktop resolutions
And updates volume-claim-template heading to the new style
Before:
After: