Skip to content

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Nov 2, 2017

More cleanup of bugs I made with #2389. I should have caught these the first two times. But on the up side, that's one more commit for the leaderboard. ;-)

Before:
screen shot 2017-11-02 at 12 12 59 pm
screen shot 2017-11-02 at 12 12 48 pm
screen shot 2017-11-02 at 12 12 41 pm

After:
screen shot 2017-11-02 at 12 12 06 pm
screen shot 2017-11-02 at 12 12 14 pm
screen shot 2017-11-02 at 12 12 20 pm

@rhamilto rhamilto requested a review from spadgett November 2, 2017 16:16
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 2, 2017
@spadgett
Copy link
Member

spadgett commented Nov 2, 2017

/hold
/kind bug
/lgtm

LGTM and seems low risk, but holding for @jwforres' approval

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 2, 2017
@jwforres
Copy link
Member

jwforres commented Nov 2, 2017

low risk
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 424cf01 into openshift:master Nov 2, 2017
@rhamilto rhamilto deleted the page-header branch November 7, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants