Add SVG icons #2208
Merged
Add SVG icons #2208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
force-pushed
the
logos
branch
5 times, most recently
from
a28e0c1 to
ae870ad
Compare
|
Icons for subcategories:
|
|
Ooohhhh purdy |
|
@jeff-phillips-18 PTAL |
dtaylor113
approved these changes
Oct 5, 2017
|
[test] since Jenkins file changed |
|
dist on this one, not tests |
Yeah, needs a common and catalog release before I can add dist |
jeff-phillips-18
approved these changes
Oct 5, 2017
openshift-ci-robot
added
the
size/XXL
Use color SVG icons when available for recognized icon classes, including those from openshift-logos.
|
Evaluated for origin web console test up to ad0d847 |
|
[merge] |
|
Evaluated for origin web console merge up to ad0d847 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/326/) (Base Commit: eb33544) (PR Branch Commit: ad0d847) |
|
Origin Web Console Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/312/) (Base Commit: eb33544) (PR Branch Commit: ad0d847) |
openshift-merge-robot
added a commit
that referenced
this pull request
Nov 1, 2017
Automatic merge from submit-queue. Fix bug where custom img icons don't appear in catalog cards Introduced with #2208 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icons from @jennyhaines
Requires openshift/origin-web-catalog#465
Requires openshift/origin-web-common#213
Before and After:
@serenamarie125 @sspeiche @rhamilto