Revert "console autodetection" #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6555bed.
|
/hold |
openshift-ci-robot
added
do-not-merge/hold
|
I'm fine with it. You'll want to be sure that regular users can see these resources. |
|
Yeah, we're already requesting PRs for origin and openshift-ansible: |
|
Console changes have merged. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
deads2k
reviewed
Feb 13, 2018
|
|
||
| var versionTemplate = template.Must(template.New("webConsoleVersion").Parse(` | ||
| window.OPENSHIFT_VERSION = { | ||
| openshift: "{{ .OpenShiftVersion | js}}", |
There was a problem hiding this comment.
you no longer need to expose this?
There was a problem hiding this comment.
Not needed anymore. We had to switch the request to the client anyway to fix a bug:
|
question. lgtm otherwise |
/retest |
openshift-merge-robot
added a commit
to openshift/origin
that referenced
this pull request
Feb 19, 2018
Automatic merge from submit-queue. Revert "allow webconsole to discover cluster information" This reverts commit 98b9fa6. /assign @deads2k /hold Requires openshift/origin-web-console-server#31
openshift-merge-robot
added a commit
to openshift/openshift-ansible
that referenced
this pull request
Mar 1, 2018
Automatic merge from submit-queue. Remove RBAC console template The console is changing to discover if the template service broker is running by looking at the service classes on the client. This means the console no longer needs the RBAC template. It also no longer needs to manually trigger a rollout after the template service broker is installed or removed. Requires: openshift/origin-web-console-server#31 openshift/origin-web-console#2800 openshift/origin-web-catalog#642 Corresponding origin PR: openshift/origin#18580 This will fail tests until the origin-web-console image is updated with the changes in the origin-web-console-server PR. /assign @sdodson @deads2k cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6555bed.
/assign @deads2k
Requires openshift/origin-web-catalog#642
Follow on openshift-ansible and origin PRs will remove the console RBAC template, which isn't needed anymore.