Skip to content

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented May 5, 2025

Version(s):
N/A, Kueue GA, kueue-docs branch only.

Issue:
https://issues.redhat.com/browse/OSDOCS-14540

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@abrennan89 abrennan89 added this to the Continuous Release milestone May 5, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2025

@abrennan89: This pull request references OSDOCS-14540 which is a valid jira issue.

In response to this:

Version(s):
N/A, Kueue GA, kueue-docs branch only.

Issue:
https://issues.redhat.com/browse/OSDOCS-14540

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2025

@abrennan89: This pull request references OSDOCS-14540 which is a valid jira issue.

In response to this:

Version(s):
N/A, Kueue GA, kueue-docs branch only.

Issue:
https://issues.redhat.com/browse/OSDOCS-14540

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2025
@abrennan89 abrennan89 force-pushed the admin-gs branch 3 times, most recently from 969ce93 to 10c83bf Compare May 12, 2025 12:39
@abrennan89 abrennan89 changed the title [WIP] OSDOCS-14540: Content journey #1: Kueue administrator getting started OSDOCS-14540: Content journey #1: Kueue administrator getting started May 12, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2025
Copy link

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asahay19
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@abrennan89 abrennan89 added the peer-review-needed Signifies that the peer review team needs to review this PR label May 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2025

@abrennan89: This pull request references OSDOCS-14540 which is a valid jira issue.

In response to this:

Version(s):
N/A, Kueue GA, kueue-docs branch only.

Issue:
https://issues.redhat.com/browse/OSDOCS-14540

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lpettyjo lpettyjo self-requested a review May 15, 2025 13:30
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 15, 2025
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that you have two commits. Not sure if you are required to squash or not. Just mentioning this if you should squash.

One comment Otherwise, LGTM!

@lpettyjo lpettyjo removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 15, 2025
@lpettyjo lpettyjo added the peer-review-done Signifies that the peer review team has reviewed this PR label May 15, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2025
Copy link

openshift-ci bot commented May 15, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented May 15, 2025

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@abrennan89 abrennan89 merged commit 91f3c8a into openshift:kueue-docs May 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants