Skip to content

Conversation

porridge
Copy link

@porridge porridge commented Feb 24, 2025

Version(s): RH ACS 4.8

Issue:

Links to docs previews:

89058--ocpdocs-pr.netlify.app/openshift-acs/latest/installing/installing_ocp/install-central-config-options-ocp.html
89058--ocpdocs-pr.netlify.app/openshift-acs/latest/installing/installing_ocp/install-secured-cluster-config-options-ocp.html

QE review: ACS has no QE, approved by SME

  • QE has approved this change.

Additional information:

This:

  • changes the overall overlay structure example at the top to be generic rather than specific to config maps, because config maps are a bit special
  • changes the configmap-specific example to show how to:
    • override just one data field rather than all of them
    • use the new verbatim field and why

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 24, 2025

@porridge: This pull request references ROX-27332 which is a valid jira issue.

This pull request references ROX-27333 which is a valid jira issue.

In response to this:

Version(s): RH ACS 4.8

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

This:

  • changes the overall overlay structure example at the top to be generic rather than specific to config maps, because config maps are a bit special
  • changes the configmap-specific example to show how to:
  • override just one data field rather than all of them
  • use the new verbatim field and why

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 24, 2025

@kcarmichael08 kcarmichael08 added peer-review-in-progress Signifies that the peer review team is reviewing this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.8 labels Mar 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2025

@porridge: This pull request references ROX-27332 which is a valid jira issue.

This pull request references ROX-27333 which is a valid jira issue.

In response to this:

Version(s): RH ACS 4.8

Issue:

Links to docs previews:

89058--ocpdocs-pr.netlify.app/openshift-acs/latest/installing/installing_ocp/install-central-config-options-ocp.html
89058--ocpdocs-pr.netlify.app/openshift-acs/latest/installing/installing_ocp/install-secured-cluster-config-options-ocp.html

QE review:

  • QE has approved this change.

Additional information:

This:

  • changes the overall overlay structure example at the top to be generic rather than specific to config maps, because config maps are a bit special
  • changes the configmap-specific example to show how to:
  • override just one data field rather than all of them
  • use the new verbatim field and why

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I marked a few style issues but otherwise LGTM!

@kcarmichael08 kcarmichael08 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 18, 2025
@kcarmichael08 kcarmichael08 added this to the Continuous Release milestone Mar 18, 2025
@porridge
Copy link
Author

Thank you @kcarmichael08 , all applied!

@kcarmichael08 kcarmichael08 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 18, 2025
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @porridge , sorry, can you 1) revert the change I noted and 2) squash all commits into one after making that change? After commits are squashed, I can merge it. Thank you!

@porridge porridge force-pushed the overlays-configmaps branch from 52c1dfd to 596babb Compare March 19, 2025 08:00
Copy link

openshift-ci bot commented Mar 19, 2025

@porridge: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2025

@porridge: This pull request references ROX-27332 which is a valid jira issue.

This pull request references ROX-27333 which is a valid jira issue.

In response to this:

Version(s): RH ACS 4.8

Issue:

Links to docs previews:

89058--ocpdocs-pr.netlify.app/openshift-acs/latest/installing/installing_ocp/install-central-config-options-ocp.html
89058--ocpdocs-pr.netlify.app/openshift-acs/latest/installing/installing_ocp/install-secured-cluster-config-options-ocp.html

QE review: ACS has no QE, approved by SME

  • QE has approved this change.

Additional information:

This:

  • changes the overall overlay structure example at the top to be generic rather than specific to config maps, because config maps are a bit special
  • changes the configmap-specific example to show how to:
  • override just one data field rather than all of them
  • use the new verbatim field and why

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 merged commit 83dfaa6 into openshift:rhacs-docs-main Mar 19, 2025
2 checks passed
@kcarmichael08
Copy link
Contributor

/cherrypick rhacs-docs-4.8

@openshift-cherrypick-robot

@kcarmichael08: new pull request could not be created: failed to create pull request against openshift/openshift-docs#rhacs-docs-4.8 from head openshift-cherrypick-robot:cherry-pick-89058-to-rhacs-docs-4.8: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:rhacs-docs-4.8 and openshift-cherrypick-robot:cherry-pick-89058-to-rhacs-docs-4.8"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherrypick rhacs-docs-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcarmichael08
Copy link
Contributor

/cherrypick rhacs-docs-4.8

@openshift-cherrypick-robot

@kcarmichael08: new pull request could not be created: failed to create pull request against openshift/openshift-docs#rhacs-docs-4.8 from head openshift-cherrypick-robot:cherry-pick-89058-to-rhacs-docs-4.8: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:rhacs-docs-4.8 and openshift-cherrypick-robot:cherry-pick-89058-to-rhacs-docs-4.8"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherrypick rhacs-docs-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.8 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants