-
Notifications
You must be signed in to change notification settings - Fork 1.8k
ROX-27332,ROX-27333: Overlays for configmaps #89058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-27332,ROX-27333: Overlays for configmaps #89058
Conversation
@porridge: This pull request references ROX-27332 which is a valid jira issue. This pull request references ROX-27333 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@porridge: This pull request references ROX-27332 which is a valid jira issue. This pull request references ROX-27333 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I marked a few style issues but otherwise LGTM!
Thank you @kcarmichael08 , all applied! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @porridge , sorry, can you 1) revert the change I noted and 2) squash all commits into one after making that change? After commits are squashed, I can merge it. Thank you!
Co-authored-by: Kerry Carmichael <[email protected]>
52c1dfd
to
596babb
Compare
@porridge: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@porridge: This pull request references ROX-27332 which is a valid jira issue. This pull request references ROX-27333 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherrypick rhacs-docs-4.8 |
@kcarmichael08: new pull request could not be created: failed to create pull request against openshift/openshift-docs#rhacs-docs-4.8 from head openshift-cherrypick-robot:cherry-pick-89058-to-rhacs-docs-4.8: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:rhacs-docs-4.8 and openshift-cherrypick-robot:cherry-pick-89058-to-rhacs-docs-4.8"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick rhacs-docs-4.8 |
@kcarmichael08: new pull request could not be created: failed to create pull request against openshift/openshift-docs#rhacs-docs-4.8 from head openshift-cherrypick-robot:cherry-pick-89058-to-rhacs-docs-4.8: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:rhacs-docs-4.8 and openshift-cherrypick-robot:cherry-pick-89058-to-rhacs-docs-4.8"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): RH ACS 4.8
Issue:
Links to docs previews:
89058--ocpdocs-pr.netlify.app/openshift-acs/latest/installing/installing_ocp/install-central-config-options-ocp.html
89058--ocpdocs-pr.netlify.app/openshift-acs/latest/installing/installing_ocp/install-secured-cluster-config-options-ocp.html
QE review: ACS has no QE, approved by SME
Additional information:
This:
data
field rather than all of themverbatim
field and why