Skip to content

ROX-17004: Updating BPF CO-RE section and adding known issue #61852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2023
Merged

ROX-17004: Updating BPF CO-RE section and adding known issue #61852

merged 1 commit into from
Jun 28, 2023

Conversation

kcarmichael08
Copy link
Contributor

@kcarmichael08 kcarmichael08 commented Jun 28, 2023 •
edited
Loading

Created from #61818 with known additional issue added.

Version(s):

  • Merge to rhacs-docs
  • Cherry pick to rhacs-docs-4.1

Issue

Link to docs preview

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2023 •
edited by openshift-ci bot
Loading

@kcarmichael08: This pull request references ROX-17004 which is a valid jira issue.

In response to this:

Created from #61818 with known additional issue added.

Version(s):

  • Merge to rhacs-docs
  • Cherry pick to rhacs-docs-4.1

Issue

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 28, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 28, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://61852--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/18903

@kcarmichael08 kcarmichael08 force-pushed the release-note-known-issue branch from 20fa2ac to f0c7805 Compare June 28, 2023 17:02
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2023 •
edited by openshift-ci bot
Loading

@kcarmichael08: This pull request references ROX-17004 which is a valid jira issue.

In response to this:

Created from #61818 with known additional issue added.

Version(s):

  • Merge to rhacs-docs
  • Cherry pick to rhacs-docs-4.1

Issue

Link to docs preview

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcarmichael08 kcarmichael08 mentioned this pull request Jun 28, 2023
Closed
1 task
robbycochran
robbycochran reviewed Jun 28, 2023
View reviewed changes
release_notes/41-release-notes.adoc Outdated
[id="known-issues_{context}"]
=== Known issues

* For secured clusters on {ibm-z} and {ibm-linuxone} that are running {ocp} 4.10, Collector fails to start. There is currently no workaround for this issue. (ROX-18058)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should mention the core_bpf workaround here, perhaps:

Suggested change
* For secured clusters on {ibm-z} and {ibm-linuxone} that are running {ocp} 4.10, Collector fails to start. There is currently no workaround for this issue. (ROX-18058)
* For secured clusters on {ibm-z} and {ibm-linuxone} that are running {ocp} 4.10, Collector fails to start using the default configuration. As a workaround, enable CORE_BPF<link to corebpf section> collection method. (ROX-18058)

@kcarmichael08 kcarmichael08 force-pushed the release-note-known-issue branch from f0c7805 to 3da57b1 Compare June 28, 2023 17:47
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2023 •
edited by openshift-ci bot
Loading

@kcarmichael08: This pull request references ROX-17004 which is a valid jira issue.

In response to this:

Created from #61818 with known additional issue added.

Version(s):

  • Merge to rhacs-docs
  • Cherry pick to rhacs-docs-4.1

Issue

Link to docs preview

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcarmichael08 kcarmichael08 added peer-review-needed Signifies that the peer review team needs to review this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.1 labels Jun 28, 2023
@bergerhoffer
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 28, 2023
bergerhoffer
bergerhoffer reviewed Jun 28, 2023
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one possible clarification

release_notes/41-release-notes.adoc Outdated
[id="known-issues_{context}"]
=== Known issues

* For secured clusters on {ibm-z} and {ibm-linuxone} that are running {ocp} 4.10, Collector fails to start using the default configuration. As a workaround, enable the xref:../release_notes/41-release-notes.adoc#new-collection-method-based-on-bpf-co-re-technology-preview_release-notes-41[CORE_BPF collection method] (Technology Preview). (ROX-18058)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this could read two ways:

  • it fails to start up when you're using the default configuration
  • it fails to begin using this configuration

If it's the former, maybe some tweak to clarify, like "Collector fails to start when the default configuration is used.". If it's the latter, then some other tweak that I can't give a suggestion for 😄

Copy link
Contributor Author

@kcarmichael08 kcarmichael08 Jun 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - it's # 1, so I will adjust accordingly!

@bergerhoffer
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 28, 2023
@agantony @kcarmichael08
ROX17004 Updating BPF CO-RE section - Silke
b06972a 
ROX17004 Updating topic map file
@kcarmichael08 kcarmichael08 force-pushed the release-note-known-issue branch from 3da57b1 to b06972a Compare June 28, 2023 18:29
@kcarmichael08 kcarmichael08 merged commit daafa74 into openshift:rhacs-docs Jun 28, 2023
@kcarmichael08 kcarmichael08 deleted the release-note-known-issue branch June 28, 2023 19:10
@kcarmichael08
Copy link
Contributor Author

/cherrypick rhacs-docs-4.1

@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #61881

In response to this:

/cherrypick rhacs-docs-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

+1 more reviewer

@robbycochran robbycochran robbycochran approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kcarmichael08 @openshift-ci-robot @ocpdocs-previewbot @bergerhoffer @openshift-cherrypick-robot @robbycochran @agantony