Skip to content

Conversation

mikemckiernan
Copy link

@mikemckiernan mikemckiernan commented Apr 20, 2021

Several devices are supported as of 4.8 and the statement
of support for three specific devices is misleading.

See callout desc #10 at https://deploy-preview-31698--osdocs.netlify.app/openshift-enterprise/latest/networking/hardware_networks/configuring-sriov-device.html#nw-sriov-networknodepolicy-object_configuring-sriov-device


@openshift/team-documentation PTAL.

Applies to branch enterprise-4.8 and milestone Future Release

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2021
@mikemckiernan
Copy link
Author

/assign @zshi-redhat
/assign @zhaozhanqi

Sorry folks, I noticed a misleading statement about the supported device IDs.

@netlify
Copy link

netlify bot commented Apr 20, 2021

Deploy preview for osdocs ready!

Built with commit 47cbba9

https://deploy-preview-31698--osdocs.netlify.app

@jboxman
Copy link
Contributor

jboxman commented Apr 20, 2021

@mikemckiernan, but I'm not sure we can do these xrefs yet.

@zshi-redhat
Copy link
Contributor

Good catch, yes we need to fix this wrong statement.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2021
@zhaozhanqi
Copy link

/lgtm

Several devices are supported as of 4.8 and the statement
of support for three specific devices is misleading.

No xref to the supported devices on the about SR-IOV page. Yet.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2021
@mikemckiernan
Copy link
Author

@mikemckiernan, but I'm not sure we can do these xrefs yet.

Yeah, that's a bummer for customers. I don't have any bright ideas for an alternative. The list of devices is valuable in the intro material--I can imagine myself as a customer and expect to find that ref material in the intro. To me, the same ref material is valuable to the customer when keying in the YAML. For now, I removed the xref and hope customers are willing to eyeball the TOC.

@mburke5678
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2021
@mburke5678 mburke5678 added this to the Future Release milestone Apr 20, 2021
@mburke5678 mburke5678 merged commit b63f066 into openshift:master Apr 20, 2021
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@mburke5678: new pull request created: #31701

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.8 lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants