Skip to content

Conversation

kmccarron-rh
Copy link
Contributor

@kmccarron-rh kmccarron-rh commented Mar 19, 2021

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 19, 2021
@netlify
Copy link

netlify bot commented Mar 19, 2021

Deploy preview for osdocs ready!

Built with commit 9be8a81

https://deploy-preview-30695--osdocs.netlify.app

@kmccarron-rh
Copy link
Contributor Author

Review requested:
@jeremyeder, @vkareh

@yufchang - Just a heads-up, this will require QE ack.
Thanks all!

@jeremyeder
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021
@sfortner-RH
Copy link
Contributor

LGTM!

@sfortner-RH sfortner-RH added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 19, 2021
@0kashi
Copy link
Contributor

0kashi commented Mar 19, 2021

In the first link:

@sfortner-RH
Copy link
Contributor

Karen can address the first two bullets, but I don't have an answer for #4. This content was already SME and QE-acked, so the only new change is the link update. But I see your point. Right now this is part of the CLI guide: https://docs.openshift.com/rosa/rosa_cli/rosa-get-started-cli.html

Would #4 fit better under "Using the Bash Script"? https://docs.openshift.com/rosa/rosa_cli/rosa-get-started-cli.html#rosa-using-bash-script_rosa-getting-started-cli

@0kashi
Copy link
Contributor

0kashi commented Mar 19, 2021

This would fit under the granting cluster-admin section which is already there. Can we just remove it from here?

@sfortner-RH
Copy link
Contributor

Works for me!

@sfortner-RH sfortner-RH removed the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 19, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2021
Copy link
Contributor

@sfortner-RH sfortner-RH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the updates Karen. Ready for QE.

@sfortner-RH sfortner-RH added peer-review-done Signifies that the peer review team has reviewed this PR lgtm Indicates that a PR is ready to be merged. QE Required labels Mar 19, 2021
@kmccarron-rh
Copy link
Contributor Author

@sfortner-RH - QE ack received in the card. Looks like we are good to merge!

@sfortner-RH sfortner-RH merged commit c680b2d into openshift:dedicated-4 Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR QE Required size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants