-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update links to Rosa CLI download #30695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for osdocs ready! Built with commit 9be8a81 |
Review requested: @yufchang - Just a heads-up, this will require QE ack. |
/lgtm |
LGTM! |
In the first link:
|
Karen can address the first two bullets, but I don't have an answer for #4. This content was already SME and QE-acked, so the only new change is the link update. But I see your point. Right now this is part of the CLI guide: https://docs.openshift.com/rosa/rosa_cli/rosa-get-started-cli.html Would #4 fit better under "Using the Bash Script"? https://docs.openshift.com/rosa/rosa_cli/rosa-get-started-cli.html#rosa-using-bash-script_rosa-getting-started-cli |
This would fit under the granting cluster-admin section which is already there. Can we just remove it from here? |
Works for me! |
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the updates Karen. Ready for QE.
@sfortner-RH - QE ack received in the card. Looks like we are good to merge! |
Jira: https://issues.redhat.com/browse/OSDOCS-1951
Here are direct links to the preview:
See Step 1 in Setting up the rosa CLI
https://deploy-preview-30695--osdocs.netlify.app/openshift-rosa/latest/rosa_cli/rosa-get-started-cli.html#rosa-setting-up-cli_rosa-getting-started-cli
See Step 4 in Setting up the environment:
https://deploy-preview-30695--osdocs.netlify.app/openshift-rosa/latest/rosa_getting_started/rosa-setting-up-environment.html#rosa-setting-up-environment_rosa-setting-up-environment