Skip to content

Conversation

bgaydosrh
Copy link

@bgaydosrh bgaydosrh commented Feb 24, 2020

Resolving bug by adding the following as a prerequisite to the Create VMs assembly:

Before creating your virtual machine, ensure your namespace is not openshift-cnv.
Create a new namespace or use another preexisting namespace that is not named
openshift-cnv.

Label Peer Review Needed and Enterprise-4.3 and Enterprise-4.4

See https://bz1799065--ocpdocs.netlify.com/openshift-enterprise/latest/cnv/cnv_virtual_machines/cnv-create-vms.html for Preview Build. Topic is Create Virtual Machines.

Bob

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

@bgaydosrh
Copy link
Author

Tagging @alexxa for QE review.

Copy link

@alexxa alexxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgaydosrh VMs shouldn'e be created in any openshift-* prefixed nses. See the bz comment #9. Thanks.

@bgaydosrh bgaydosrh force-pushed the BZ1799065 branch 2 times, most recently from eecaa4a to 9cba35c Compare March 9, 2020 14:52
@bgaydosrh
Copy link
Author

@bgaydosrh VMs shouldn'e be created in any openshift-* prefixed nses. See the bz comment #9. Thanks.

Done. Changed text to: "* Before creating your virtual machine, ensure your namespace does not start
with openshift (openshift-*). Create a new namespace or use another
preexisting namespace that does not start with openshift."

@bgaydosrh
Copy link
Author

Ready for Peer Review.

Copy link
Contributor

@aburdenthehand aburdenthehand Mar 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an admonition, not a prerequisite, and since it can lead to loss of service it should probably be a warning admonition:

[WARNING]
====
Do not create virtual machines in `openshift-*` namespaces. 
Create a new namespace or use an existing namespace that does not have the `openshift-*` prefix.
====

And for layout reasons, I'd move it after the 'Use one of these procedures to...' list

Copy link
Author

@bgaydosrh bgaydosrh Mar 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks. Had some strange formatting problems in Atom, where the * was not rendering.

Warning reads:

Do not create virtual machines in openshift-* namespaces.
Instead, create a new namespace or use an existing namespace without the
openshift prefix.

@aburdenthehand aburdenthehand merged commit 95ed41b into openshift:master Mar 9, 2020
@aburdenthehand
Copy link
Contributor

/cherrypick enterprise-4.3

@openshift-cherrypick-robot

@aburdenthehand: new pull request created: #20361

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aburdenthehand
Copy link
Contributor

/cherrypick enterprise-4.4

@openshift-cherrypick-robot

@aburdenthehand: new pull request created: #20362

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants