VMware NSX-T SDN Install and Config updates #14709

mburke5678 · 2019-05-05T22:08:07Z

Follow-up to #14649

mburke5678 · 2019-05-05T22:10:08Z

@aheslin FYI I created a PR for the Vmware nsxt issue.
#14649
I thought it quicker to add my edits here. This is a first pass. LMK if we are going forward with this.

openshift-docs-preview-bot · 2019-05-05T22:11:15Z

The preview will be availble shortly at:

https://vmware-nsxt--ocpdocs.netlify.com/

vikram-redhat · 2019-05-06T06:16:20Z

@mburke5678 in case you don't get a response from Ali, yes, we are going ahead with it.

Does this supercede #14649?

mburke5678 · 2019-05-06T20:04:11Z

install_config/configuring_nsxtsdn.adoc

@vikram-redhat Do we want to refer people out to the OpenShift install docs here and remove the command?

mburke5678 · 2019-05-06T20:04:35Z

install_config/configuring_nsxtsdn.adoc

@vikram-redhat Do we want to refer people out to the OpenShift install prerequisite docs here and remove the command?

mburke5678 · 2019-05-06T20:17:10Z

@RobbieJVMW Can you review my changes? I want to make sure my efforts to change the wording and such to better fit the OpenShift docs doesn't change any technical meaning.
Also, I have a few questions in #14649

mburke5678 · 2019-05-07T13:34:09Z

@ousleyp Can you review this partner doc? They want it live by tomorrow for Summit.

ahardin-rh · 2019-05-07T18:57:40Z

architecture/topics/nsxt.adoc

ahardin-rh · 2019-05-07T18:59:46Z

architecture/topics/nsxt.adoc

s/OpenShift Container Platform/{product-title}

ahardin-rh · 2019-05-07T18:59:59Z

architecture/topics/nsxt.adoc

s/datacenter/data center

"NSX-T Data Center" is the product name. :)

ahardin-rh · 2019-05-07T19:01:13Z

architecture/topics/nsxt.adoc

s/Cetner/Center

Not sure Data Center is a proper noun here. If not, I think we can lower case it.

Agree in this context it should probably say "NSX-T Manager" rather than "NSX-T Data Center"

I believe that is the name of the product.
https://www.vmware.com/products/nsx.html

The NSX-T Container Plug-In (NCP) integrates {product-title} into an NSX-T Manager, which is typically configured for the entire datacenter.

ahardin-rh · 2019-05-07T19:03:09Z

install_config/configuring_nsxtsdn.adoc

s/refer to the/refer to

ahardin-rh · 2019-05-07T19:09:59Z

install_config/configuring_nsxtsdn.adoc

s/LoadBalancer/load balancer

@ahardin-rh Is this a kubernetes object, here? They use LoadBalancer.

ahardin-rh · 2019-05-07T19:10:14Z

install_config/configuring_nsxtsdn.adoc

topology, the

ahardin-rh · 2019-05-07T19:10:52Z

install_config/configuring_nsxtsdn.adoc

point to the infrastructure node IP addresses?

ahardin-rh · 2019-05-07T19:11:17Z

install_config/configuring_nsxtsdn.adoc

s/LoadBalancer/load balancer

ahardin-rh · 2019-05-07T19:11:48Z

install_config/configuring_nsxtsdn.adoc

s/3/three
s/4/four

ahardin-rh · 2019-05-07T19:12:23Z

install_config/configuring_nsxtsdn.adoc

s/LoadBalancer/load balancer

ahardin-rh · 2019-05-07T19:12:42Z

install_config/configuring_nsxtsdn.adoc

ahardin-rh · 2019-05-07T19:13:24Z

install_config/configuring_nsxtsdn.adoc

s/Plugin/Plug-in

ahardin-rh · 2019-05-07T19:15:49Z

install_config/configuring_nsxtsdn.adoc

s/plugin/plug-in
s/in NCP Tar file/in the NCP tar file
s/vmWare/VMware

Did they change vmWare? Could sworn it was that way, but you are right....

ahardin-rh · 2019-05-07T19:16:15Z

install_config/configuring_nsxtsdn.adoc

s/setup/set up

ahardin-rh · 2019-05-07T19:17:48Z

install_config/configuring_nsxtsdn.adoc

s/OpenShift Container Platform/{product-title}

@ahardin-rh Do we want to change that one to {product-title}? It is the name of the section in the link.

ahardin-rh · 2019-05-07T19:18:29Z

install_config/configuring_nsxtsdn.adoc

For example, check

ahardin-rh · 2019-05-07T19:19:53Z

@mburke5678 Just some minor comments from me. Otherwise, looks good!

mburke5678 · 2019-05-07T20:19:41Z

@ahardin-rh Thanks for the great (and quick) review!

mburke5678 · 2019-05-07T22:50:08Z

Per Robbie in email:
One of my NSX specialists have already taken a look at the preview site and didn’t flag anything. He knows NSX far better than I so I would consider that a green light.

mburke5678 · 2019-05-08T01:43:25Z

/cherrypick enterprise-3.11

openshift-cherrypick-robot · 2019-05-08T01:43:26Z

@mburke5678: once the present PR merges, I will cherry-pick it on top of enterprise-3.11 in a new PR and assign it to you.

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2019-05-08T01:44:32Z

@mburke5678: new pull request created: #14754

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 5, 2019

mburke5678 changed the title ~~Vmware nsxt~~ VMware NSX-T SDN Install and Config updates May 5, 2019

mburke5678 commented May 6, 2019

View reviewed changes

mburke5678 force-pushed the vmware-nsxt branch from 9fdb6a0 to e49cfc3 Compare May 6, 2019 21:53

mburke5678 added the branch/enterprise-3.11 label May 7, 2019

mburke5678 added this to the Future Release milestone May 7, 2019

ahardin-rh reviewed May 7, 2019

View reviewed changes

architecture/topics/nsxt.adoc Outdated

Copy link

Contributor

ahardin-rh May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, which

ahardin-rh reviewed May 7, 2019

View reviewed changes

architecture/topics/nsxt.adoc Outdated

Copy link

Contributor

ahardin-rh May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/OpenShift Container Platform/{product-title}

ahardin-rh reviewed May 7, 2019

View reviewed changes

install_config/configuring_nsxtsdn.adoc Outdated

Copy link

Contributor

ahardin-rh May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/refer to the/refer to

ahardin-rh reviewed May 7, 2019

View reviewed changes

install_config/configuring_nsxtsdn.adoc Outdated

Copy link

Contributor

ahardin-rh May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

topology, the

ahardin-rh reviewed May 7, 2019

View reviewed changes

install_config/configuring_nsxtsdn.adoc Outdated

Copy link

Contributor

ahardin-rh May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

point to the infrastructure node IP addresses?

ahardin-rh reviewed May 7, 2019

View reviewed changes

install_config/configuring_nsxtsdn.adoc Outdated

Copy link

Contributor

ahardin-rh May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/LoadBalancer/load balancer

ahardin-rh reviewed May 7, 2019

View reviewed changes

install_config/configuring_nsxtsdn.adoc Outdated

Copy link

Contributor

ahardin-rh May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/3/three
s/4/four

ahardin-rh reviewed May 7, 2019

View reviewed changes

install_config/configuring_nsxtsdn.adoc Outdated

Copy link

Contributor

ahardin-rh May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/LoadBalancer/load balancer

ahardin-rh reviewed May 7, 2019

View reviewed changes

install_config/configuring_nsxtsdn.adoc Outdated

Copy link

Contributor

ahardin-rh May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/&/and

ahardin-rh reviewed May 7, 2019

View reviewed changes

install_config/configuring_nsxtsdn.adoc Outdated

Copy link

Contributor

ahardin-rh May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Plugin/Plug-in

ahardin-rh reviewed May 7, 2019

View reviewed changes

install_config/configuring_nsxtsdn.adoc Outdated

Copy link

Contributor

ahardin-rh May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/setup/set up

ahardin-rh reviewed May 7, 2019

View reviewed changes

install_config/configuring_nsxtsdn.adoc Outdated

Copy link

Contributor

ahardin-rh May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, check

ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label May 7, 2019

mburke5678 force-pushed the vmware-nsxt branch from 26a5ae7 to 672cd54 Compare May 8, 2019 00:43

VMware NSX-T SDN Install and Config updates

61f63f7

mburke5678 force-pushed the vmware-nsxt branch from 672cd54 to 61f63f7 Compare May 8, 2019 01:26

mburke5678 merged commit ad09df7 into openshift:master May 8, 2019

mburke5678 deleted the vmware-nsxt branch May 8, 2019 01:44

openshift-cherrypick-robot mentioned this pull request May 8, 2019

[enterprise-3.11] VMware NSX-T SDN Install and Config updates #14754

Merged

This was referenced May 9, 2019

NSX-T SDN Documentation update #14695

Closed

NSX-T SDN Documentation update #14800

Merged

VMware NSX-T SDN Install and Config updates #14709

VMware NSX-T SDN Install and Config updates #14709

Uh oh!

Conversation

mburke5678 commented May 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mburke5678 commented May 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-docs-preview-bot commented May 5, 2019

Uh oh!

vikram-redhat commented May 6, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mburke5678 commented May 6, 2019

Uh oh!

mburke5678 commented May 7, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahardin-rh commented May 7, 2019

Uh oh!

mburke5678 commented May 7, 2019

Uh oh!

mburke5678 commented May 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mburke5678 commented May 8, 2019

Uh oh!

openshift-cherrypick-robot commented May 8, 2019

mburke5678 commented May 5, 2019 •

edited

Loading

mburke5678 commented May 5, 2019 •

edited

Loading

mburke5678 commented May 7, 2019 •

edited

Loading