Skip to content

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Apr 18, 2018

We're checking for a timeout but if we abort for any reason other than timeout we're not passing it back.

TASK [Approve bootstrap nodes] *************************************************
Wednesday 18 April 2018  20:50:10 +0000 (0:00:00.067)       0:12:25.319 ******* 
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: KeyError: 'timeout'
fatal: [ocp-master]: FAILED! => {"changed": false, "module_stderr": "Traceback (most recent call last):\n  File \"/tmp/ansible_h7bav4mq/ansible_module_oc_adm_csr.py\", line 1723, in <module>\n    main()\n  File \"/tmp/ansible_h7bav4mq/ansible_module_oc_adm_csr.py\", line 1713, in main\n    rval['timeout']):\nKeyError: 'timeout'\n", "module_stdout": "", "msg": "MODULE FAILURE", "rc": 1}
...ignoring

@sdodson sdodson requested a review from kwoodson April 18, 2018 21:19
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2018
@sdodson sdodson requested a review from abutcher April 18, 2018 21:19
@sdodson sdodson mentioned this pull request Apr 18, 2018
@sdodson
Copy link
Member Author

sdodson commented Apr 19, 2018

bot, retest this please

@sdodson
Copy link
Member Author

sdodson commented Apr 19, 2018

/retest

@abutcher
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2018
@openshift-merge-robot openshift-merge-robot merged commit aed1ce6 into openshift:master Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants