OCPBUGS-59311: oc adm must-gather: Perform cleanup on signal received

[tchap]

The command now removes any temporary resources on signal received,
i.e. the whole temp namespace generally, or just the pods in case
--run-namespace is specified.

Since there is no way to interrupt log streaming in kubectl currently,
I ended up just pulling kubectl logs in as an internal package and adding RunLogsContext.
I sent a PR to add the method into upstream as well, but that will be only available
as we rebase onto the next release.

Let me know if you have any better idea. I did that because some
of the methods on LogOptions are private, so I couldn't reimplement
the logic without basically rewriting the while thing anyway.

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-59311, which is invalid:

• expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The command now removes any temporary resources on signal received,
i.e. the whole temp namespace generally, or just the pods in case
--run-namespace is specified.

Since there is no way to interrupt log streaming in kubectl currently,
I ended up just pulling kubectl logs in as an internal package and adding RunLogsContext.
I sent a PR to add the method into upstream as well, but that will be only available
as we rebase onto the next release.

Let me know if you have any better idea. I did that because some
of the methods on LogOptions are private, so I couldn't reimplement
the logic without basically rewriting the while thing anyway.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tchap]

/jira refresh

[openshift-ci-robot]

@tchap: This pull request references Jira Issue OCPBUGS-59311, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tchap
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tchap]

Ok, let's wait until kubernetes/kubernetes#133067 is merged and available. We will revisit the PR then.

[openshift-ci]

@tchap: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-certrotation	71dd73e	link	false	/test e2e-aws-certrotation
ci/prow/verify	71dd73e	link	true	/test verify
ci/prow/unit	71dd73e	link	true	/test unit
ci/prow/security	71dd73e	link	false	/test security
ci/prow/okd-scos-e2e-aws-ovn	71dd73e	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-serial-2of2	71dd73e	link	true	/test e2e-aws-ovn-serial-2of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tchap]

/hold

until the upstream PR and function becomes available.