Skip to content

Add HTTP01 ACME test for cert-manager #5320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add HTTP01 ACME test for cert-manager #5320

wants to merge 1 commit into from
+394 −89

Conversation

kasturinarra
Copy link

  • Add new test case for cert-manager with local ACME server (Pebble) using HTTP01 challenge
  • Include Pebble server deployment configuration
  • Add keywords for DNS name retrieval, certificate verification, and cleanup

🤖 Generated with Claude Code

Which issue(s) this PR addresses: Creating a local acme server to t

Closes #

@openshift-ci openshift-ci bot requested review from copejon and jerpeter1 August 13, 2025 10:23
@kasturinarra
Copy link
Author

kasturinarra commented Aug 13, 2025 •
edited
Loading

@eslutsky could you please help review ? thanks !!
I have tried to add /etc/hosts entry but that kind of does not work here, and since QE vms have dns resolvable name i used that for now. May be we could discucss once you are back.

@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch 7 times, most recently from e9b49cb to 52f744f Compare August 18, 2025 07:43
eslutsky
eslutsky reviewed Aug 18, 2025
View reviewed changes
test/suites/optional/cert-manager.robot Outdated
${subject_alt_names_line}= Get Lines Containing String ${config_content} subjectAltNames:
${first_line}= Get Line ${subject_alt_names_line} 0
${alt_names_content}= Get Regexp Matches ${first_line} \\[(.+?)\\] 1
VAR ${alt_names_list}= ${alt_names_content}[0]
# Get the first DNS name (before the first comma)
${first_dns_name}= Split String ${alt_names_list} , 1
${dns_name}= Strip String ${first_dns_name}[0]
Should Not Be Empty ${dns_name} msg=Failed to retrieve DNS name from MicroShift config
RETURN ${dns_name}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
${subject_alt_names_line}= Get Lines Containing String ${config_content} subjectAltNames:
${first_line}= Get Line ${subject_alt_names_line} 0
${alt_names_content}= Get Regexp Matches ${first_line} \\[(.+?)\\] 1
VAR ${alt_names_list}= ${alt_names_content}[0]
# Get the first DNS name (before the first comma)
${first_dns_name}= Split String ${alt_names_list} , 1
${dns_name}= Strip String ${first_dns_name}[0]
Should Not Be Empty ${dns_name} msg=Failed to retrieve DNS name from MicroShift config
RETURN ${dns_name}
${config_yaml}= Evaluate yaml.safe_load('''${config_content}''') modules=yaml
${first_dns_name}= Get From List ${config_yaml['apiServer']['subjectAltNames']} 0
Should Not Be Empty ${first_dns_name} msg=Failed to retrieve DNS name from MicroShift config
RETURN ${first_dns_name}

you can evalulate the config as yaml file and get the first item from subjectAltNames .

@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch 5 times, most recently from e017908 to f686a50 Compare August 20, 2025 11:23
@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch from f686a50 to bfeef46 Compare September 3, 2025 11:27
@kasturinarra
Copy link
Author

/test security

@kasturinarra
Copy link
Author

/test e2e-aws-tests-arm

@kasturinarra
Copy link
Author

/test e2e-aws-tests-bootc

@kasturinarra
Copy link
Author

/test e2e-aws-tests-bootc-arm

@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch 2 times, most recently from 345336c to 1172447 Compare September 5, 2025 11:35
@kasturinarra kasturinarra marked this pull request as draft September 5, 2025 11:52
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025
@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch from 1172447 to 4f7de9b Compare September 5, 2025 15:58
@kasturinarra kasturinarra marked this pull request as ready for review September 5, 2025 16:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025
@openshift-ci openshift-ci bot requested a review from pmtk September 5, 2025 16:07
@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch from 4f7de9b to 88ab792 Compare September 5, 2025 17:29
eslutsky
eslutsky reviewed Sep 9, 2025
View reviewed changes
@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch from 88ab792 to 50042e2 Compare September 10, 2025 18:09
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasturinarra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
@kasturinarra
Copy link
Author

/test e2e-aws-tests-bootc-arm

@kasturinarra
Copy link
Author

/test e2e-aws-tests-bootc

@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch 3 times, most recently from a94c185 to 90f2e06 Compare September 11, 2025 10:52
eslutsky
eslutsky reviewed Sep 17, 2025
View reviewed changes
@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch from 90f2e06 to 5bff3a4 Compare September 17, 2025 11:07
@kasturinarra
Copy link
Author

/test e2e-aws-tests-bootc

2 similar comments
@kasturinarra
Copy link
Author

/test e2e-aws-tests-bootc

@kasturinarra
Copy link
Author

/test e2e-aws-tests-bootc

@kasturinarra
Copy link
Author

/test e2e-aws-tests-bootc-arm

@kasturinarra
Copy link
Author

/test e2e-aws-tests-bootc

eslutsky
eslutsky reviewed Sep 25, 2025
View reviewed changes
eslutsky
eslutsky reviewed Sep 26, 2025
View reviewed changes
@kasturinarra kasturinarra force-pushed the cert-manager-http01-test branch from 5bff3a4 to 05a632f Compare September 26, 2025 18:19
@kasturinarra
Copy link
Author

@eslutsky addressed all your comments, can you please help review again ? thanks !!

@kasturinarra
Copy link
Author

/test e2e-aws-tests-bootc-arm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 26, 2025

@kasturinarra: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copejon copejon Awaiting requested review from copejon

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@pmtk pmtk Awaiting requested review from pmtk

1 more reviewer

@eslutsky eslutsky eslutsky left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasturinarra @eslutsky