-
Notifications
You must be signed in to change notification settings - Fork 447
TRT-2232: Revert #5148 "OCPBUGS-58023: Prevent unnecessary systemd unit disable" #5213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRT-2232: Revert #5148 "OCPBUGS-58023: Prevent unnecessary systemd unit disable" #5213
Conversation
@stbenjam: This pull request references TRT-2232 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
@stbenjam: This pull request references TRT-2232 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/e2e-gcp-op-2of2 |
@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-aws-serial, ci/prow/e2e-azure-ovn-upgrade, ci/prow/e2e-azure-ovn-upgrade-out-of-change, ci/prow/e2e-gcp-mco-disruptive, ci/prow/e2e-gcp-op-1of2, ci/prow/e2e-gcp-op-2of2, ci/prow/e2e-gcp-op-ocl, ci/prow/e2e-gcp-op-single-node, ci/prow/e2e-hypershift, ci/prow/okd-scos-e2e-aws-ovn, ci/prow/security In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/e2e-agent-compact-ipv4 |
@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-agent-compact-ipv4, ci/prow/e2e-aws-mco-disruptive, ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-aws-ovn-upgrade-out-of-change, ci/prow/e2e-aws-ovn-windows In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@stbenjam: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
Reverts #5148 ; tracked by TRT-2232
Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.
machine-config operator causing azure, metal and other platforms to fail to install
To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:
CC: @RishabhSaini