Round trip #533
Round trip #533
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bn222 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
bn222
force-pushed
the
round-trip
branch
2 times, most recently
from
98d920c to
aa8248b
Compare
Signed-off-by: Balazs Nemeth <[email protected]>
bn222
force-pushed
the
round-trip
branch
2 times, most recently
from
8295219 to
bdd7c9c
Compare
|
@wizhaoredhat ptal |
bn222
force-pushed
the
round-trip
branch
2 times, most recently
from
a004e1f to
5ca6cef
Compare
|
/test ci/prow/make-prow-ci-manifests-check |
|
@bn222: The specified target(s) for Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test make-prow-ci-manifests-check |
Signed-off-by: Balazs Nemeth <[email protected]>
|
/test make-e2e-test |
|
/test make-e2e-test-marvell |
|
@bn222: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| "Intel IPU E2100": images.VspImageIntel, | ||
| "Marvell OCTEON": images.VspImageMarvell, | ||
| "NetSec Accelerator": images.VspImageIntelNetSec, | ||
| } |
There was a problem hiding this comment.
will build it dynamically
| @@ -6,6 +6,7 @@ metadata: | |||
| subjects: | |||
| - kind: ServiceAccount | |||
| name: vsp-sa | |||
| namespace: {{.Namespace}} | |||
| name: host-root | ||
| - mountPath: /var/run/ | ||
| name: vendor-plugin-sock | ||
| - mountPath: /opt/p4/p4-cp-nws/var |
There was a problem hiding this comment.
think about this still
| type IntelDetector struct { | ||
| name string | ||
| } | ||
|
|
||
| func NewIntelDetector() *IntelDetector { | ||
| return &IntelDetector{name: "Intel IPU"} | ||
| return &IntelDetector{name: "Intel IPU E2100"} |
There was a problem hiding this comment.
const and reuse so that we don't make a mistake against the string
To avoid split-brain issues, move the creation and management of vsp pod to controller manager.