Skip to content

NO-JIRA: feat: update the ip parsing for the nodes #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NO-JIRA: feat: update the ip parsing for the nodes #1479

wants to merge 1 commit into from
+100 −7

Conversation

eggfoobar
Copy link
Contributor

@eggfoobar eggfoobar commented Sep 4, 2025 •
edited
Loading

updated the logic for the cluster info to use net package and added unit tests for dualstack behavior to select first ip address

@openshift-ci openshift-ci bot requested review from clobrano and jaypoulz September 4, 2025 05:05
tjungblu
tjungblu reviewed Sep 4, 2025
View reviewed changes
clobrano
clobrano suggested changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@clobrano clobrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments

clobrano
clobrano suggested changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@clobrano clobrano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, that was a Gemini test that went wrong 😁

@eggfoobar
feat: update the ip parsing for the nodes
4e7cc8d 
updated the logic for the cluster info to use net package and added unit tests for dualstack behavior to select first ip address

Signed-off-by: ehila <[email protected]>
@eggfoobar eggfoobar force-pushed the upkeep-tnf-cluster-config-ip branch from 5ae4bc9 to 4e7cc8d Compare September 4, 2025 15:08
clobrano
clobrano approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@clobrano clobrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 5, 2025
@slintes
Copy link
Member

slintes commented Sep 6, 2025

/lgtm
/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, eggfoobar, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eggfoobar eggfoobar changed the title feat: update the ip parsing for the nodes NO-JIRA: feat: update the ip parsing for the nodes Sep 9, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2025
@openshift-ci-robot
Copy link

@eggfoobar: This pull request explicitly references no jira issue.

In response to this:

updated the logic for the cluster info to use net package and added unit tests for dualstack behavior to select first ip address

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar
Copy link
Contributor Author

/verified by @eggfoobar

No behavioral changes, I built a payload with this change deployed a dualstack cluster with ipv4 as the first element in the interface, this was correctly chosen as the main IP sent down to pacemaker. I validated via the setup job and the options passed to pacemaker.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 9, 2025
@openshift-ci-robot
Copy link

@eggfoobar: This PR has been marked as verified by @eggfoobar.

In response to this:

/verified by @eggfoobar

No behavioral changes, I built a payload with this change deployed a dualstack cluster with ipv4 as the first element in the interface, this was correctly chosen as the main IP sent down to pacemaker. I validated via the setup job and the options passed to pacemaker.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 61b7fb5 and 2 for PR HEAD 4e7cc8d in total

4 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 61b7fb5 and 2 for PR HEAD 4e7cc8d in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 61b7fb5 and 2 for PR HEAD 4e7cc8d in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 61b7fb5 and 2 for PR HEAD 4e7cc8d in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 61b7fb5 and 2 for PR HEAD 4e7cc8d in total

@eggfoobar
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 61b7fb5 and 2 for PR HEAD 4e7cc8d in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 61b7fb5 and 2 for PR HEAD 4e7cc8d in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 61b7fb5 and 2 for PR HEAD 4e7cc8d in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-etcd-scaling 4e7cc8d link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-aws-etcd-recovery 4e7cc8d link false /test e2e-aws-etcd-recovery
ci/prow/e2e-gcp-disruptive-ovn 4e7cc8d link false /test e2e-gcp-disruptive-ovn
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 4e7cc8d link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-aws-disruptive-ovn 4e7cc8d link false /test e2e-aws-disruptive-ovn
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 4e7cc8d link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-vsphere-ovn-etcd-scaling 4e7cc8d link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-aws-disruptive 4e7cc8d link false /test e2e-aws-disruptive
ci/prow/e2e-gcp-disruptive 4e7cc8d link false /test e2e-gcp-disruptive
ci/prow/e2e-gcp-ovn-etcd-scaling 4e7cc8d link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-metal-ovn-two-node-fencing 4e7cc8d link false /test e2e-metal-ovn-two-node-fencing
ci/prow/e2e-metal-assisted 4e7cc8d link true /test e2e-metal-assisted
ci/prow/e2e-aws-ovn-etcd-scaling 4e7cc8d link true /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-serial 4e7cc8d link true /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 61b7fb5 and 2 for PR HEAD 4e7cc8d in total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypoulz jaypoulz Awaiting requested review from jaypoulz

2 more reviewers

@tjungblu tjungblu tjungblu left review comments

@clobrano clobrano clobrano approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@slintes slintes

@clobrano clobrano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eggfoobar @slintes @openshift-ci-robot @clobrano @tjungblu