Skip to content

Conversation

igsilya
Copy link

@igsilya igsilya commented Jul 11, 2025

Manual port of the #6490 due to conflicting previously merged PRs:

This change aims to do two things:

  • Start listening for changs when libreswan sees an update This can happen now libreswan is not pinned anymore
  • Get an annotation in the consistency checks if rhcos and ovn have different versions for libreswan. ovn-miicroshift is not yet needed

(cherry-picked from commit 48c1d3a)

The libreswan package was un-pinned in 4.18 ovn-k via openshift/ovn-kubernetes#2593 (relevant diff).

CC: @joepvd

This change aims to do two things:
- Start listening for changs when libreswan sees an update
  This can happen now libreswan is not pinned anymore
- Get an annotation in the consistency checks if rhcos and ovn have
  different versions for libreswan. ovn-miicroshift is not yet needed

(cherry-picked from commit 48c1d3a)
[i.maximets] Conflicts resolved due to previous PRs:
  * openshift-eng#6940
  * openshift-eng#6736
Copy link
Contributor

@joepvd joepvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2025
Copy link
Contributor

openshift-ci bot commented Jul 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3666566 into openshift-eng:openshift-4.18 Jul 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants