Enable rhel 7.5 and docker 1.13 #1061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
| @@ -22,7 +22,7 @@ actions: | |||
| - type: "host_script" | |||
| title: "install docker" | |||
| script: |- | |||
| oct prepare docker --repourl "https://mirror.openshift.com/enterprise/rhel/dockertested/x86_64/os/" --repo 'oso-rhui-rhel-server-*' | |||
| oct prepare docker --version '1.13' --repo 'oso-rhui-rhel-server-*' | |||
There was a problem hiding this comment.
err, keep the dockertested for the 1.13 install
|
@stevekuznetsov If you insist on it working, fine. |
|
/lgtm |
|
We failed to get the test suite passing with docker1.13 due to a websocket issue |
Seems to be fixed in openshift/origin#18755 |
| @@ -4,7 +4,7 @@ set -eu | |||
| BASE_DIR=/mnt/redhat | |||
| REMOTE_DIR=/srv/enterprise/rhel | |||
| LATEST_RHEL_COMPOSE=${BASE_DIR}/nightly/latest-RHEL-7 | |||
| LATEST_EXTRAS=${BASE_DIR}/nightly/EXTRAS-RHEL-7.4/latest-EXTRAS-7-RHEL-7/compose/Server/x86_64/os | |||
| LATEST_EXTRAS=${BASE_DIR}/nightly/EXTRAS-RHEL-7.5/latest-EXTRAS-7-RHEL-7/compose/Server/x86_64/os | |||
There was a problem hiding this comment.
seems scary if our AMI is still 7.4 yeah?
|
Should be able to yum upgrade. If not then there are problems. |
|
OK, will add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.