Skip to content

add openssl hmac defensive test #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2015
Merged

add openssl hmac defensive test #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/ngx_http_set_hmac.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ ngx_http_set_misc_set_hmac_sha1(ngx_http_request_t *r, ngx_str_t *res,
ngx_http_variable_value_t *v)
{
ngx_http_variable_value_t *secret, *string_to_sign;
unsigned int md_len;
unsigned int md_len = 0;
unsigned char md[EVP_MAX_MD_SIZE];
const EVP_MD *evp_md;

Expand All @@ -32,6 +32,12 @@ ngx_http_set_misc_set_hmac_sha1(ngx_http_request_t *r, ngx_str_t *res,
HMAC(evp_md, secret->data, secret->len, string_to_sign->data,
string_to_sign->len, md, &md_len);

/* defensive test if there is something wrong with openssl */
if (md_len == 0 || md_len > EVP_MAX_MD_SIZE) {
res->len = 0;
return NGX_ERROR;
}

res->len = md_len;
ndk_palloc_re(res->data, r->pool, md_len);

Expand Down