Skip to content

Fix a minor bug in #1601 #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2025
Merged

Fix a minor bug in #1601 #1669

merged 1 commit into from
Sep 8, 2025

Conversation

seratch
Copy link
Member

@seratch seratch commented Sep 5, 2025

This pull request resolves this issue: #1601 (comment)

@seratch seratch requested a review from rm-openai September 5, 2025 06:50
@seratch seratch added bug Something isn't working feature:core labels Sep 5, 2025
rm-openai
rm-openai approved these changes Sep 8, 2025
View reviewed changes
Copy link
Collaborator

@rm-openai rm-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming this is safe/backwards compatible/wont cause any regressions?

@seratch
Copy link
Member Author

seratch commented Sep 8, 2025

Yeah, this shouldn't cause any issues for the existing apps, plus it must be consistent with the actual type name for future users.

@seratch seratch merged commit 5ef3020 into main Sep 8, 2025
5 checks passed
@seratch seratch deleted the tool-name-fix branch September 8, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm-openai rm-openai rm-openai approved these changes

Assignees
No one assigned
Labels
bug Something isn't working feature:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seratch @rm-openai