HDF5 filters (compression) #1644
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }; | ||
|
|
||
| template <typename JSON, typename Accessor> | ||
| auto parse_filter_by_id(JSON &filter_config, Accessor &&json_accessor) |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
franzpoeschel
force-pushed
the
hdf5-filters
branch
from
c13d131 to
17e41dd
Compare
franzpoeschel
force-pushed
the
hdf5-filters
branch
2 times, most recently
from
23f7be5 to
233f020
Compare
franzpoeschel
commented
Oct 25, 2024
src/IO/HDF5/HDF5IOHandler.cpp
Outdated
| if (parameters.joinedDimension.has_value()) | ||
| { | ||
| error::throwOperationUnsupportedInBackend( | ||
| "ADIOS1", "Joined Arrays currently only supported in ADIOS2"); |
franzpoeschel
force-pushed
the
hdf5-filters
branch
from
233f020 to
9f2b4a9
Compare
franzpoeschel
force-pushed
the
hdf5-filters
branch
2 times, most recently
from
f52b83c to
bd479f4
Compare
franzpoeschel
force-pushed
the
hdf5-filters
branch
from
bd479f4 to
19650ed
Compare
franzpoeschel
force-pushed
the
hdf5-filters
branch
from
19650ed to
fbd70a7
Compare
franzpoeschel
force-pushed
the
hdf5-filters
branch
from
fbd70a7 to
c82c69c
Compare
franzpoeschel
force-pushed
the
hdf5-filters
branch
2 times, most recently
from
960e461 to
3579385
Compare
franzpoeschel
force-pushed
the
hdf5-filters
branch
from
3579385 to
dcadd76
Compare
franzpoeschel
force-pushed
the
hdf5-filters
branch
7 times, most recently
from
2b977a6 to
8a40230
Compare
franzpoeschel
commented
Jul 29, 2025
Compression example is moved to 15_compression now
This is too bothersome to set up and the runs that we have are enough.
franzpoeschel
force-pushed
the
hdf5-filters
branch
from
30ac839 to
70a86ad
Compare
franzpoeschel
force-pushed
the
hdf5-filters
branch
from
39a26e1 to
a4d3d44
Compare
This reverts commit b81437b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for filters (e.g. compression) in HDF5.
TODO:
maybe add some helpersDiff: franzpoeschel/openPMD-api@hdf5-independent-flush-config...hdf5-filters