-
Notifications
You must be signed in to change notification settings - Fork 264
Labels
area:azurebugSomething isn't workingSomething isn't workingtoolingRegarding build, workflows, build-tools, ...Regarding build, workflows, build-tools, ...
Description
⚠ Please DO NOT release semconv artifacts based on v1.35.0 ⚠
#1698 renamed a bunch of cloud.platform
members from azure_
to azure.
which causes collisions similar to #1118 when generating code - the constant/enum member name is exactly the same for azure_aks
and azure.aks
.
E.g. on JS
> tsc --build tsconfig.json tsconfig.esm.json tsconfig.esnext.json
src/experimental_attributes.ts:1448:14 - error TS2451: Cannot redeclare block-scoped variable 'CLOUD_PLATFORM_VALUE_AZURE_AKS'.
1448 export const CLOUD_PLATFORM_VALUE_AZURE_AKS = "azure.aks" as const;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/experimental_attributes.ts:1483:14 - error TS2451: Cannot redeclare block-scoped variable 'CLOUD_PLATFORM_VALUE_AZURE_AKS'.
1483 export const CLOUD_PLATFORM_VALUE_AZURE_AKS = "azure_aks" as const;
We'll need to:
- Support
annotation
mechanism to exclude old values from codegen similar to attributes - it does not apply to enum members today - Annotations for enum members weaver#812 - Add policy preventing such collisions in future - Member collisions policies: id, value, const name #2456
- Update semconv and annotate problematic enum members
- Release 1.35.1 patch
Metadata
Metadata
Assignees
Labels
area:azurebugSomething isn't workingSomething isn't workingtoolingRegarding build, workflows, build-tools, ...Regarding build, workflows, build-tools, ...
Type
Projects
Status
Core SemConv issues