Skip to content

Conversation

hectorhdzg
Copy link
Member

@hectorhdzg hectorhdzg requested a review from a team January 2, 2020 20:14
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one non-blocking question: is it worth updating the WSGI integration at the same time?

@hectorhdzg hectorhdzg changed the title Updating network connection attributes names to latest (pymongo) Updating network connection attributes names to latest in spec Jan 6, 2020
@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.77%. Comparing base (4458698) to head (c07d9c2).

Files with missing lines Patch % Lines
...ry-ext-wsgi/src/opentelemetry/ext/wsgi/__init__.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
- Coverage   84.82%   84.77%   -0.06%     
==========================================
  Files          38       38              
  Lines        1839     1839              
  Branches      217      217              
==========================================
- Hits         1560     1559       -1     
  Misses        214      214              
- Partials       65       66       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hectorhdzg hectorhdzg added the PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Jan 7, 2020
@toumorokoshi toumorokoshi merged commit a89bbc8 into open-telemetry:master Jan 7, 2020
@c24t c24t removed the PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Jan 29, 2020
@hectorhdzg hectorhdzg deleted the hectorhdzg/pymongo branch March 24, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants