Skip to content

Remove TestBase assertEqualSpanInstrumentationInfo when no longer used #4301

@tammy-baylis-swi

Description

@tammy-baylis-swi

Is your feature request related to a problem?

Yes, open-telemetry/opentelemetry-python-contrib#3033

Describe the solution you'd like

It would be nice if we could remove assertEqualSpanInstrumentationInfo because it results in deprecation warnings. See contrib issue open-telemetry/opentelemetry-python-contrib#3033

Maybe we could do this step-wise:

  1. Remove all contrib uses (Stop TestBase DeprecationWarnings from instrumentor test span info checks opentelemetry-python-contrib#3033)
  2. There doesn't seem to be any core uses (grep)
  3. For a few releases, have assertEqualSpanInstrumentationInfo log warnings that it will be removed in a future release.
  4. Remove assertEqualSpanInstrumentationInfo.

Describe alternatives you've considered

Or keep it forever?

Additional Context

n/a

Would you like to implement a fix?

Yes

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions