[WIP] Update google genai instrumentation to work with latest semantic convention, allow for uploading content. #3772
+500
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aaron Abbott <[email protected]>
|
aabmass
reviewed
Sep 23, 2025
| ]: | ||
| attributes.update(completion_details_attributes) | ||
| event = Event(name="gen_ai.completion.details", attributes=attributes) | ||
| hook = load_upload_hook() |
There was a problem hiding this comment.
I think the instrumentor class should do a DI pattern for this. It probably should accept an optional upload hook as a parameter to instrument(), otherwise use load_upload_hook().
Comment on lines
+466
to
+474
| ContentCapturingMode.SPAN_ONLY, | ||
| ContentCapturingMode.SPAN_AND_EVENT, | ||
| ]: | ||
| span = trace.get_current_span() | ||
| span.set_attributes(completion_details_attributes) | ||
| if self._content_recording_enabled in [ | ||
| ContentCapturingMode.EVENT_ONLY, | ||
| ContentCapturingMode.SPAN_AND_EVENT, | ||
| ]: |
There was a problem hiding this comment.
@DylanRussell should we still do this if there is an upload hook? One practical concern for GCP logging exporter is that if you include the JSON in the log directly and it exceeds the size limit (256kB) the whole log gets dropped. Since the upload hook works on the same log, that would mean everything gets dropped.
Alternatively, maybe we could emit two separate logs to avoid this problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accomodation of semantic conventions changes made in open-telemetry/semantic-conventions#2179.
Also, when logging the completion details, the upload hook is called, so if user has configured
OTEL_INSTRUMENTATION_GENAI_UPLOAD_BASE_PATHandOTEL_INSTRUMENTATION_GENAI_UPLOAD_HOOKenv vars, completion details will also be logged as refs (if appropriate capture content env var is set).Type of change
How Has This Been Tested?
WIP, only some manual tests for now.
Does This PR Require a Core Repo Change?
No?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.