openai: Remove llm_request_attributes of type NOT_GIVEN to avoid excessive warning messages

[benkawecki]

Description

This PR filters out attributes where the value is NOT_GIVEN form the llm_request_attributes dictionary. The type of NOT_GIVEN cannot be set as an attribute value which creates a warning message for users. Note this only occurs if a user directly sets the value to be NOT_GIVEN, it doesn't occur for default values.

This warning message is generated in opentelemetry.attributes here.

Example WARNING log:

WARNING  opentelemetry.attributes:__init__.py:111 Invalid type NotGiven for attribute 'top_p' value. Expected one of ['bool', 'str', 'bytes', 'int', 'float'] or a sequence of those types

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
This behavior can be confirmed by passing NOT_GIVEN directly into a completions.create function call:

from openai import OpenAI, NOT_GIVEN

client = OpenAI()
response = client.chat.completions.create(
    messages=[{"role": "user", "content": "Say this is a test"}],
    model=llm_model_value,
    top_p=NOT_GIVEN,
)

I've added this test case into the unittest.

• test_chat_completion_handles_not_given

Does This PR Require a Core Repo Change?

• Yes. - Link to PR:
• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: benkawecki / name: Ben Kawcki (36f4e87)

[benkawecki]

Note to reviewers, I'm unsure what the best way to update the cassette / VCR configurations is. If you have guidance for that please let me know.

[xrmx]

Note to reviewers, I'm unsure what the best way to update the cassette / VCR configurations is. If you have guidance for that please let me know.

You remove the cassette and it gets recreated when you run tests again

[benkawecki]

Note to reviewers, I'm unsure what the best way to update the cassette / VCR configurations is. If you have guidance for that please let me know.

You remove the cassette and it gets recreated when you run tests again

Ack. I'll have to do this later tonight then since I need to be on a different machine to hit the openai api. If you have any other issues with the PR lmk and I can resolve them.

[rads-1996]

Instead of explicitly defining this logic here, would it make more sense to create a function for this similar to - non_numerical_value_is_set ?